Add API and CI codeowners #136
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owner isn't a defined roll within the org? What does it mean to be an owner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to define a new team to be used as codeowners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But as a project, what is an owner? How do I become one? It's not a defined role I can have. There are no qualifications but somehow folks have membership in a team that grants some privileges to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i think we don't yet have a clear definition of this role and how one would get into this group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Istio, we have nested maintainer roles such as networking/ztunnel. Every ztunnel maintainer is a networking maintainer but not every networking maintainer is a ztunnel maintainer. Is this essentially meant to be nested like that? If you are a kgw maintainer you can also be a kgw/api maintainer for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think it's reasonable that "kgateway api maintainer" would be a subset of "kgateway controller maintainer".
if we are calling this a new "maintainer" group then do we also need to have a formal process that's documented in https://github.com/kgateway-dev/community/blob/main/CONTRIBUTOR_LADDER.md#maintainer? in Istio how does one become a ztunnel maintainer for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like controller/api makes sense to me. I don't think we need a specific ladder per se. If you qualify to be controller/api you should naturally meet the qualifications of the more general controller I'd suspect. Do we imagine this won't be the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was more asking the other way around - if you are already a (more general) controller maintainer, what extra qualifications do you need to become a controller api maintainer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Enough pr/reviews/knowledge/involvement in the API area. Trust of the other API maintainers.