Skip to content

Videojs8 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Videojs8 #143

wants to merge 7 commits into from

Conversation

@7Ds7
Copy link

@7Ds7 7Ds7 commented Sep 5, 2023

No description provided.

7Ds7 and others added 7 commits January 15, 2020 19:50
@7Ds7
VideoJs warnings
dfc6b0e 
- plugin is now registerPlugin
- videojs.addClass is now videojs.dom.addClass
@7Ds7
More changes to videojs 7
9c23135 
- Make resolution hover
- changed to handleTechSeeked_
- force resolution switch to change label
@7Ds7
Removed commented lines
c1105b5
@7Ds7
bump videojs version
5d904fb
@7Ds7
bumped videojs devDependency
8e1345f
@7Ds7
Fixing lint errors
2e2942a
@7Ds7
Changes for videojs 8
976d4e1
@jacobgkau
Copy link

jacobgkau commented May 11, 2025 •
edited
Loading

This port's working, but lines 81 & 89 are missing a check for this.options().dynamicLabel before applying the resolution to the button label. (Without adding it, the default resolution is added to the label, although it isn't updated when the resolution's changed.)

The CSS for the button's :before also needs to have its content updated from \f110 to \f114, since the cog/gear icon has moved positions in the VideoJS font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@7Ds7 @jacobgkau