Skip to content

Commit bc048dc

Browse files
fmudrychmeliik
authored andcommitted
modify check_tekton_tasks script
With this new approach, we will check only changed tasks, making this step faster and we won't waste resources. Signed-off-by: Filip Mudry <[email protected]>
1 parent a6b6a79 commit bc048dc

File tree

2 files changed

+32
-30
lines changed

2 files changed

+32
-30
lines changed

.github/scripts/check_tekton_tasks.sh

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,23 @@ set -euo pipefail
77
# Please consider sending a PR upstream instead of editing the file directly.
88
# See the SHARED-CI.md document in this repo for more details.
99

10+
if [ "$#" -eq 0 ]; then
11+
echo "No changed task directories provided, nothing to validate"
12+
exit 0
13+
fi
14+
1015
echo ">>> Applying and validating Tekton Tasks"
1116

12-
for task_folder in task/*/; do
13-
if [ -d "$task_folder" ]; then
14-
task_name="$(basename "$task_folder")"
15-
echo ">>> Validating Task: $task_name"
16-
17-
(
18-
cd "$task_folder"
19-
for version in */; do
20-
if [ -d "$version" ]; then
21-
kubectl apply -f "$version/$task_name.yaml" --dry-run=server
22-
fi
23-
done
24-
)
25-
fi
17+
for TASK_DIR in "$@"; do
18+
TASK_NAME=$(basename "$(dirname "$TASK_DIR")")
19+
TASK_YAML_PATH="${TASK_DIR}/${TASK_NAME}.yaml"
20+
21+
if [ -f "$TASK_YAML_PATH" ]; then
22+
echo ">>> Validating Task: $TASK_YAML_PATH"
23+
kubectl apply -f "$TASK_YAML_PATH" --dry-run=server
24+
else
25+
echo "INFO: Task YAML not found at '$TASK_YAML_PATH'. A non-YAML file was changed, skipping..."
26+
fi
2627
done
2728

28-
echo ">>> All tasks validated successfully."
29+
echo ">>> All changed tasks validated successfully."

{{cookiecutter.repo_root}}/.github/scripts/check_tekton_tasks.sh

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,23 @@ set -euo pipefail
77
# Please consider sending a PR upstream instead of editing the file directly.
88
# See the SHARED-CI.md document in this repo for more details.
99

10+
if [ "$#" -eq 0 ]; then
11+
echo "No changed task directories provided, nothing to validate"
12+
exit 0
13+
fi
14+
1015
echo ">>> Applying and validating Tekton Tasks"
1116

12-
for task_folder in task/*/; do
13-
if [ -d "$task_folder" ]; then
14-
task_name="$(basename "$task_folder")"
15-
echo ">>> Validating Task: $task_name"
16-
17-
(
18-
cd "$task_folder"
19-
for version in */; do
20-
if [ -d "$version" ]; then
21-
kubectl apply -f "$version/$task_name.yaml" --dry-run=server
22-
fi
23-
done
24-
)
25-
fi
17+
for TASK_DIR in "$@"; do
18+
TASK_NAME=$(basename "$(dirname "$TASK_DIR")")
19+
TASK_YAML_PATH="${TASK_DIR}/${TASK_NAME}.yaml"
20+
21+
if [ -f "$TASK_YAML_PATH" ]; then
22+
echo ">>> Validating Task: $TASK_YAML_PATH"
23+
kubectl apply -f "$TASK_YAML_PATH" --dry-run=server
24+
else
25+
echo "INFO: Task YAML not found at '$TASK_YAML_PATH'. A non-YAML file was changed, skipping..."
26+
fi
2627
done
2728

28-
echo ">>> All tasks validated successfully."
29+
echo ">>> All changed tasks validated successfully."

0 commit comments

Comments
 (0)