@@ -84,7 +84,7 @@ func (fr *FirewallCR) Sync(nodeNames, additionalPorts, additionalRanges []string
8484 ranges .Insert (additionalRanges ... )
8585
8686 fr .logger .V (3 ).Info ("Firewall CR is enabled." )
87- expectedFirewallCR , err := NewFirewallCR (name , ports .List (), ranges .UnsortedList (), []string {}, ! fr .dryRun )
87+ expectedFirewallCR , err := NewFirewallCR (name , ports .List (), ranges .UnsortedList (), []string {}, fr .dryRun )
8888 if err != nil {
8989 return err
9090 }
@@ -141,14 +141,14 @@ func deleteFirewallCR(client firewallclient.Interface, name string, logger klog.
141141}
142142
143143// NewFirewallCR constructs the firewall CR from name, ports and ranges
144- func NewFirewallCR (name string , ports , srcRanges , dstRanges []string , enforced bool ) (* gcpfirewallv1.GCPFirewall , error ) {
144+ func NewFirewallCR (name string , ports , srcRanges , dstRanges []string , dryRun bool ) (* gcpfirewallv1.GCPFirewall , error ) {
145145 firewallCR := & gcpfirewallv1.GCPFirewall {
146146 ObjectMeta : metav1.ObjectMeta {
147147 Name : name ,
148148 },
149149 Spec : gcpfirewallv1.GCPFirewallSpec {
150150 Action : gcpfirewallv1 .ActionAllow ,
151- Disabled : ! enforced ,
151+ Disabled : dryRun ,
152152 },
153153 }
154154 var protocolPorts []gcpfirewallv1.ProtocolPort
0 commit comments