Skip to content

Conversation

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Dec 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/aws Issues or PRs related to aws provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2025
@upodroid
Copy link
Member Author

upodroid commented Dec 6, 2025

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman December 6, 2025 12:36
@hakman
Copy link
Member

hakman commented Dec 6, 2025

@upodroid I would prefer to not cherry-pick the distros support part. It's a new feature.
For CCM, I don't have any objection bumping it, as it adds the missing ARM64 support.

@upodroid
Copy link
Member Author

upodroid commented Dec 6, 2025

The thing is we do run the distros against an older kops version and they are perma-failing right now. Do we want to tweak the grid so that certain distros don't run against specific kops versions?

@hakman
Copy link
Member

hakman commented Dec 8, 2025

The thing is we do run the distros against an older kops version and they are perma-failing right now. Do we want to tweak the grid so that certain distros don't run against specific kops versions?

@upodroid I think it would be better to skip, but only for the grid. We will move to 1.35 pretty soon with the rest of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation area/nodeup area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants