Skip to content

Commit c4714fd

Browse files
committed
fix(FR-1682): remove hardcoded password from noVNC redirect URL (#4657)
resolves ([FR-1682](https://lablup.atlassian.net/browse/FR-1682)) <!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. --> This addresses the security issue where the password used for authentication during noVNC connections is included in the redirect URL. Removing the password portion from the URL requires users to manually enter their password when accessing via noVMC. ![image.png](https://app.graphite.com/user-attachments/assets/bf63cef7-77a2-4965-8482-aef3573f21a4.png) <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1682]: https://lablup.atlassian.net/browse/FR-1682?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 879081b commit c4714fd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

resources/app_template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@
151151
"name": "novnc",
152152
"title": "VNC (Web)",
153153
"category": "6.Desktop Environment",
154-
"redirect": "/vnc.html?autoconnect=true&amp;password=backendai",
154+
"redirect": "/vnc.html?autoconnect=true",
155155
"src": "./resources/icons/novnc.svg"
156156
}
157157
],

0 commit comments

Comments
 (0)