Skip to content

feat(FR-1656): enhance file browser session notifications with primary app option #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Nov 11, 2025
Merged

feat(FR-1656): enhance file browser session notifications with primary app option #4602

graphite-app merged 1 commit into from
Nov 11, 2025

Conversation

@ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Nov 7, 2025 •
edited by atlassian bot
Loading

Resolves #4598 (FR-1656)

Summary

This PR enhances file browser session notifications by adding a primary app option for file browser, similar to how Jupyter notebooks are handled. This helps users understand when they're creating file browser-specific sessions.

Changes

  • Added new BAIFileBrowserIcon React component for file browser icon
  • Added file browser SVG icon asset
  • Enhanced SessionActionButtons to support "filebrowser" as a primary app option
  • Updated FolderExplorerHeader to pass filebrowser app option in session notifications

Test Plan

  • File browser icon displays correctly in session action buttons
  • Session notifications properly indicate file browser sessions
  • Primary app option works for both Jupyter and file browser

@ironAiken2 ironAiken2 mentioned this pull request Nov 7, 2025
Merged
5 tasks
@github-actions github-actions bot added the size:L 100~500 LoC label Nov 7, 2025
@ironAiken2 Graphite App
Copy link
Contributor Author

ironAiken2 commented Nov 7, 2025 •
edited by yomybaby
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

Coverage report for ./packages/backend.ai-ui

St.❔
 Category Percentage Covered / Total
🔴 Statements 49.62% 132/266
🔴 Branches 29.96% 80/267
🔴 Functions 33.33% 20/60
🔴 Lines 51.95% 120/231

Test suite run success

55 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from a1d6866

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
4.62% (-0% 🔻)
 530/11470
🔴 Branches
3.73% (-0% 🔻)
 302/8090
🔴 Functions
2.88% (-0% 🔻)
 102/3539
🔴 Lines
4.57% (-0% 🔻)
 512/11215

Test suite run success

121 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e601415

@ironAiken2 ironAiken2 force-pushed the feat/FR-1656-enhance-file-browser-session-notifications branch from 3b148b9 to 05729f9 Compare November 7, 2025 07:22
@ironAiken2 ironAiken2 marked this pull request as ready for review November 7, 2025 07:22
@yomybaby yomybaby changed the base branch from feat/FR-1093-migrate-file-browser-function-to-react to graphite-base/4602 November 10, 2025 01:45
@ironAiken2 ironAiken2 force-pushed the feat/FR-1656-enhance-file-browser-session-notifications branch from 05729f9 to eeeeac7 Compare November 10, 2025 05:47
@ironAiken2 ironAiken2 changed the base branch from graphite-base/4602 to feat/FR-1093-migrate-file-browser-function-to-react November 10, 2025 05:48
@ironAiken2 ironAiken2 mentioned this pull request Nov 10, 2025
Merged
5 tasks
@ironAiken2 ironAiken2 force-pushed the feat/FR-1656-enhance-file-browser-session-notifications branch from eeeeac7 to e601415 Compare November 10, 2025 05:59
nowgnuesLee
nowgnuesLee approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the feat/FR-1656-enhance-file-browser-session-notifications branch from e601415 to 7e13156 Compare November 11, 2025 02:16
@yomybaby yomybaby force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 5d2a259 to 6b7cef3 Compare November 11, 2025 02:16
@yomybaby yomybaby mentioned this pull request Nov 11, 2025
Merged
yomybaby
yomybaby approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with #4612

@ironAiken2 ironAiken2 force-pushed the feat/FR-1656-enhance-file-browser-session-notifications branch from 7e13156 to d4928e6 Compare November 11, 2025 05:44
@graphite-app
Copy link

graphite-app bot commented Nov 11, 2025 •
edited
Loading

Merge activity

@ironAiken2
feat(FR-1656): enhance file browser session notifications with primar…
a1d6866 
…y app option (#4602)

Resolves #4598 ([FR-1656](https://lablup.atlassian.net/browse/FR-1656))

## Summary
This PR enhances file browser session notifications by adding a primary app option for file browser, similar to how Jupyter notebooks are handled. This helps users understand when they're creating file browser-specific sessions.

## Changes
- Added new `BAIFileBrowserIcon` React component for file browser icon
- Added file browser SVG icon asset
- Enhanced `SessionActionButtons` to support "filebrowser" as a primary app option
- Updated `FolderExplorerHeader` to pass filebrowser app option in session notifications

## Test Plan
- [x] File browser icon displays correctly in session action buttons
- [x] Session notifications properly indicate file browser sessions
- [x] Primary app option works for both Jupyter and file browser

[FR-1656]: https://lablup.atlassian.net/browse/FR-1656?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app bot force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 6b7cef3 to 2bd9044 Compare November 11, 2025 07:57
@graphite-app graphite-app bot force-pushed the feat/FR-1656-enhance-file-browser-session-notifications branch from d4928e6 to a1d6866 Compare November 11, 2025 07:58
Base automatically changed from feat/FR-1093-migrate-file-browser-function-to-react to main November 11, 2025 08:00
@graphite-app graphite-app bot merged commit a1d6866 into main Nov 11, 2025
8 of 9 checks passed
@graphite-app graphite-app bot deleted the feat/FR-1656-enhance-file-browser-session-notifications branch November 11, 2025 08:00
@yomybaby yomybaby mentioned this pull request Nov 12, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yomybaby yomybaby yomybaby approved these changes

@nowgnuesLee nowgnuesLee nowgnuesLee approved these changes

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@ironAiken2 ironAiken2

Labels

size:L 100~500 LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance File Browser Session Notifications and Workflow Guidance

4 participants

@ironAiken2 @yomybaby @nowgnuesLee