Repository navigation
chore(LinearAlgebra): generalize IsAdjointPair - #44358
Open
TJHeeringa wants to merge 2 commits into
Open
TJHeeringa wants to merge 2 commits into
TJHeeringa wants to merge 2 commits into
Conversation
PR summary 46b43b82aaImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request has conflicts, please merge |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implemented definition
IsAdjointPairrequired sesquilinear maps. This is a stronger requirement than necessary. This PR relaxes the conditions onIsAdjointPairto the minimal ones.This is needed to generalize the RKHS from
InnerProductSpace/Reproducing.lean.The location of the definition is still
LinearAlgebra/SesquilinearForm/Basic. That is clearly not a good fit. However, I don't know a better location either. Places likeLinearAlgebra/BilinearForm/Basicare also dealing with a less general construction.