Skip to content

chore(LinearAlgebra): generalize IsAdjointPair - #44358

Open
TJHeeringa wants to merge 2 commits into
leanprover-community:masterfrom
TJHeeringa:generalize_isAdjointPair
Open

TJHeeringa wants to merge 2 commits into
leanprover-community:masterfrom
TJHeeringa:generalize_isAdjointPair

Conversation

@TJHeeringa

Copy link
Copy Markdown
Contributor

The implemented definition IsAdjointPair required sesquilinear maps. This is a stronger requirement than necessary. This PR relaxes the conditions on IsAdjointPair to the minimal ones.


This is needed to generalize the RKHS from InnerProductSpace/Reproducing.lean.

The location of the definition is still LinearAlgebra/SesquilinearForm/Basic. That is clearly not a good fit. However, I don't know a better location either. Places like LinearAlgebra/BilinearForm/Basic are also dealing with a less general construction.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

PR summary 46b43b82aa

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 46b43b8).

  • +6 new declarations
  • −0 removed declarations
+LinearMap.instSMulCommClass_1
+LinearMap.instSMulCommClass_2
+LinearMap.instSMulCommClass_3
+LinearMap.instSMulCommClass_4
+LinearMap.instSMulCommClass_5
+LinearMap.instSMulCommClass_6

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 46b43b82aa
Reference commit c20717eaa7

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 30, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant