Skip to content

Commit a27fa9d

Browse files
authored
Delegate clang-tidy -Werror enforcement to CMake instead of setting in .clang-tidy (#690)
1 parent 06458f6 commit a27fa9d

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.clang-tidy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ Checks: >
4141
-portability-template-virtual-member-function,
4242
-readability-magic-numbers
4343
44-
WarningsAsErrors: "*"
4544
HeaderFilterRegex: '.*/(modules|tasks)/.*'
4645

4746
CheckOptions:

.github/workflows/static-analysis-pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
- name: CMake configure
4848
run: >
4949
cmake -S . -B build -G Ninja
50-
-D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
50+
-D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
5151
env:
5252
CC: clang-21
5353
CXX: clang++-21
@@ -96,7 +96,7 @@ jobs:
9696
- name: CMake configure
9797
run: >
9898
cmake -S . -B build -G Ninja
99-
-D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
99+
-D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
100100
env:
101101
CC: gcc-14
102102
CXX: g++-14

0 commit comments

Comments
 (0)