fix phpunit test trigger semindependent

Author: bluetom

classes/processor.php

@@ -300,7 +300,7 @@ public function process_course_interactive($processid) {
      * @throws \coding_exception
      * @throws \dml_exception
      */
-    public function get_course_recordset($triggers, $nositecourse = true, $forcounting = false) {
+    public function  get_course_recordset($triggers, $nositecourse = true, $forcounting = false) {
         global $DB, $SESSION;
 
         $where = " TRUE ";

trigger/semindependent/lib.php

@@ -59,9 +59,9 @@ public function check_course($course, $triggerid) {
     public function get_course_recordset_where($triggerid) {
         $exclude = settings_manager::get_settings($triggerid, settings_type::TRIGGER)['exclude'];
         if ($exclude) {
-            $where = " NOT c.startdate > :semindepdate";
+            $where = " NOT c.startdate < :semindepdate";
         } else {
-            $where = "c.startdate > :semindepdate";
+            $where = "c.startdate < :semindepdate";
         }
         // Date before which a course counts as semester independent. In this case the 1.1.2000.
         $params = ["semindepdate" => 946688400];

trigger/semindependent/tests/trigger_test.php

@@ -57,7 +57,7 @@ public function setUp(): void {
         $this->resetAfterTest(true);
         $this->setAdminUser();
         $this->processor = new processor();
-        $this->semindependentcourse = $this->getDataGenerator()->create_course(['startdate' => 915152400]);
+        $this->semindependentcourse = $this->getDataGenerator()->create_course(['startdate' => 946600000]);
         $this->semcourse = $this->getDataGenerator()->create_course(['startdate' => time()]);
     }
 
@@ -69,15 +69,15 @@ public function test_include_semester_independent(): void {
 
         $this->triggerinstance = generator::create_workflow_with_semindependent(false);
 
-        $recordset = $this->processor->get_course_recordset([$this->triggerinstance]);
+        $triggeredcourses = $this->processor->get_course_recordset([$this->triggerinstance]);
         $foundsem = false;
         $foundsemindep = false;
-        foreach ($recordset as $element) {
-            if ($this->semcourse->id === $element->id) {
+        foreach ($triggeredcourses as $triggeredcourse) {
+            if ($triggeredcourse->id === $this->semcourse->id) {
                 $foundsem = true;
                 break;
             }
-            if ($this->semindependentcourse->id === $element->id) {
+            if ($triggeredcourse->id === $this->semindependentcourse->id) {
                 $foundsemindep = true;
                 break;
             }