Skip to content

Conversation

@iinuwa
Copy link
Member

@iinuwa iinuwa commented Aug 13, 2025

Closes #83.

@iinuwa iinuwa force-pushed the architecture-docs branch from 1049080 to 7ec93ab Compare August 13, 2025 23:09
@iinuwa iinuwa force-pushed the contributor-guide branch from a70da6c to d38b1cd Compare August 13, 2025 23:10
Copy link
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and such

Copy link
Member

@AlfioEmanueleFresta AlfioEmanueleFresta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great writeup!

@@ -0,0 +1,194 @@
Welcome! Thanks for looking into contributing to our project!

# Table of Contents

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may make sense to share most of this document across repositories, so we could have here a link to .github (https://github.com/linux-credentials/.github), WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking that a lot of this could apply to both repos. Do you mean moving CONTRIBUTING.md to the .github repo, and then changing this file to link to there?

I'm not opposed, but I'd appreciate your help determining what to break apart.

@iinuwa iinuwa force-pushed the architecture-docs branch from 07d6fa5 to e17d0c9 Compare August 14, 2025 20:53
Base automatically changed from architecture-docs to main August 14, 2025 20:55
@iinuwa iinuwa dismissed AlfioEmanueleFresta’s stale review August 14, 2025 20:55

The base branch was changed.

@iinuwa iinuwa force-pushed the contributor-guide branch from 43c24c4 to e972821 Compare August 14, 2025 20:57
@iinuwa iinuwa merged commit 5e7c902 into main Aug 14, 2025
1 check passed
@iinuwa iinuwa deleted the contributor-guide branch August 14, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md

4 participants