[pppanghu77]

修复：onlyTransfer 模式下断网弹出两个网络断开提示框

问题

UOS 向 Windows 投送文件过程中断开 UOS 端网络，Win 端的 dde-cooperation-transfer 弹出两个网络断开提示框，期望只弹一个。必现。

根因

dde-cooperation-transfer 在 Win 端同时加载 cooperation-core 和 data-transfer/core 两个插件，各自启动独立的 1 秒网络监控定时器，均轮询 getFirstIp().size() > 0。断网时两个定时器先后发射 onlineStateChanged(false)，分别驱动协同窗口（mainwindow.cpp）和迁移窗口（mainwindow_p_win.cpp）切换到网络断开页面，用户看到两个提示框。

根因点在 CooperaionCorePlugin::start() 中无条件调用 mainWindow()->show() 和 MainController::instance()->start()，未检查 onlyTransfer 属性。

修复方案

在 CooperaionCorePlugin::start() 中增加 onlyTransfer 检查：

• 当 onlyTransfer=true 时，跳过 mainWindow()->show()（不显示协同窗口）和 MainController::instance()->start()（不启动协同模块网络监控定时器）
• 保留基础服务（regist()、配置、翻译）
• 从源头消除重复网络监控，仅保留数据迁移侧的单监控器

改动

• src/plugins/cooperation/core/cooperationcoreplugin.cpp：start() 函数增加 onlyTransfer 条件检查（+5 行 -2 行）

影响

• onlyTransfer=true 模式：协同窗口不再显示，协同模块网络监控不启动，断网仅弹一个提示框
• 正常协同模式（onlyTransfer=false）：行为完全不变
• 基础服务：regist 等基础服务在 onlyTransfer 模式下仍正常执行

PMS: BUG-241813

Summary by Sourcery

Bug Fixes:

• Prevent duplicate network-disconnection prompts in onlyTransfer mode by disabling the cooperation UI and its redundant network monitoring.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pppanghu77

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the cooperation core plugin startup path so onlyTransfer mode does not launch the cooperation UI or its duplicate network monitor, leaving the data-transfer monitor as the sole source of network-disconnection prompts while preserving shared registrations and normal-mode behavior.

Sequence diagram for onlyTransfer startup behavior

sequenceDiagram
    participant Plugin as CooperaionCorePlugin
    participant App as qApp
    participant UI as CooperationMainWindow
    participant Controller as MainController
    participant Transfer as DataTransferMonitor

    Plugin->>App: property(onlyTransfer)
    Plugin->>Controller: regist()
    Plugin->>Transfer: regist()
    alt onlyTransfer is false
        Plugin->>UI: show()
        Plugin->>Controller: start()
        Controller-->>Controller: Start cooperation network monitor
    else onlyTransfer is true
        Plugin-->>UI: UI remains hidden
        Plugin-->>Controller: Cooperation monitor remains stopped
        Transfer-->>Transfer: Continue data-transfer network monitor
    end

Loading

File-Level Changes

Change	Details	Files
Gate cooperation UI startup and network monitoring on the onlyTransfer application property while retaining shared service registration.	Read the onlyTransfer flag at startup. Skip showing the cooperation window in transfer-only mode. Skip starting the cooperation controller and its network monitor in transfer-only mode. Continue registering the main, transfer, and cooperation services. Leave normal cooperation-mode behavior unchanged.	src/plugins/cooperation/core/cooperationcoreplugin.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 100 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	本次提交在 onlyTransfer 模式下跳过协作 UI 显示和 MainController 启动，逻辑清晰、语法正确。 四维度均通过，无安全漏洞，代码质量良好。OCR 建议复用局部变量以提升一致性，属改进建议。

---

🔍 详细分析

1. 语法逻辑 ✅

评价： 语法正确，逻辑清晰 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

2. 代码质量 ✅

评价： 代码结构清晰，注释完整 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： ['建议将第67行 !qApp->property("onlyTransfer").toBool() 改为 !onlyTransfer，复用已声明的局部变量，提升代码一致性和可维护性']

---

3. 代码性能 ✅

评价： 性能良好，资源使用合理 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

4. 代码安全 🔒

评价： 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： []

---

💡 改进建议代码示例

// 建议复用 onlyTransfer 局部变量，将第67行也统一使用该变量： bool CooperaionCorePlugin::start() {
    bool onlyTransfer = qApp->property("onlyTransfer").toBool();
    if (!onlyTransfer)
        CooperationUtil::instance()->mainWindow()->show();
    MainController::instance()->regist();
    TransferHelper::instance()->regist();
    CooperationManager::instance()->regist();
    if (!onlyTransfer)
        MainController::instance()->start();

    if (CommonUitls::isFirstStart() && !onlyTransfer) {  // 复用局部变量
#ifdef linux
        // ...
#endif
    }
    return true;
}

---

本报告由 AI 代码审查工具自动生成