-
Notifications
You must be signed in to change notification settings - Fork 115
Fix and add patterns in language_java, language_kotlin and language_groovy.
#475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PerilousBooklet
wants to merge
62
commits into
lite-xl:master
Choose a base branch
from
PerilousBooklet:PR_java_constants
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix and add patterns in language_java, language_kotlin and language_groovy.
#475
PerilousBooklet
wants to merge
62
commits into
lite-xl:master
from
PerilousBooklet:PR_java_constants
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Member
|
Yeah, but the regex in the PR is different. |
Contributor
Author
|
The one in the PR is the the old one. |
Member
Yeah, we might as well. |
…for Java and constants pattern for Java and Kotlin.
…x patterns still using double apices.
…eference inside a method's ()
Contributor
Author
|
Ok, now it should be much better. |
…ated kotlin annotation patterns; fixed groovy .class pattern.
…ged primitive data type patterns from keyword2 to keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test this PR with:
git clone https://github.com/PerilousBooklet/lite-xl-plugins.gitgit fetch && git checkout PR_java_constantslpm run --ephemeral ./ language_java