Skip to content

Conversation

@PerilousBooklet
Copy link
Contributor

@PerilousBooklet PerilousBooklet commented Aug 10, 2024

You can test this PR with:

  • git clone https://github.com/PerilousBooklet/lite-xl-plugins.git
  • git fetch && git checkout PR_java_constants
  • lpm run --ephemeral ./ language_java

@PerilousBooklet PerilousBooklet marked this pull request as ready for review October 3, 2024 17:17
@PerilousBooklet
Copy link
Contributor Author

PerilousBooklet commented Nov 21, 2024

rescue tells me that the attack fails with [A-Z](?:A-Z_\d?)+(?=\s*[)]|[\;]|[\,]|[\s\=]|[\.]) .

@Guldoman
Copy link
Member

Yeah, but the regex in the PR is different.

@PerilousBooklet
Copy link
Contributor Author

The one in the PR is the the old one.

@PerilousBooklet PerilousBooklet marked this pull request as draft November 29, 2024 18:44
@PerilousBooklet PerilousBooklet marked this pull request as ready for review November 29, 2024 19:50
@PerilousBooklet PerilousBooklet marked this pull request as draft November 29, 2024 20:09
@Guldoman
Copy link
Member

Guldoman commented Jan 7, 2025

Should I also do it for all other syntax plugins ?

Yeah, we might as well.

@PerilousBooklet
Copy link
Contributor Author

Ok, now it should be much better.

@PerilousBooklet PerilousBooklet marked this pull request as draft January 16, 2025 23:06
@PerilousBooklet PerilousBooklet marked this pull request as ready for review February 25, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants