Enhance Dockerfile to manage tokenizers binary download #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Dockerfile to handle missing prebuilt binaries for tokenizers by attempting to download them first, and falling back to building from source if not found. Signed-off-by: Vivek Sharma <[email protected]>
zdtsw
reviewed
Nov 25, 2025
| # Ensure that the RELEASE_VERSION matches the one used in the imported llm-d-kv-cache-manager version | ||
| ARG RELEASE_VERSION=v1.22.1 | ||
| RUN curl -L https://github.com/daulet/tokenizers/releases/download/${RELEASE_VERSION}/libtokenizers.${TARGETOS}-${TARGETARCH}.tar.gz | tar -xz -C lib | ||
| # Handle ppc64le or missing prebuilt binaries |
Contributor
There was a problem hiding this comment.
isnt the avaiable release for v1.22.1 only for arm64 and amd64 ?
so you should uplift RELEASE_VERSION to v1.24.0 instead adding build-from-source
Contributor
There was a problem hiding this comment.
@vMaroon do we have plan uplift to 1.24.0 https://github.com/llm-d/llm-d-kv-cache-manager/blob/main/go.mod#L8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Dockerfile to handle missing prebuilt binaries for tokenizers by attempting to download them first, and falling back to building from source if not found.