IR: fix getSwappedCmpPredicate() return type (#120097)

artagnon · web-flow · commit 290f38cd1a9f · 2024-12-16T16:29:21.000Z
The change 51a895a (IR: introduce struct with CmpInst::Predicate and samesign) missed a change to ICmpInst::getSwappedCmpPredicate(), which intends to return a CmpPredicate, but returns a Predicate instead. Fix this.
diff --git a/llvm/include/llvm/IR/Instructions.h b/llvm/include/llvm/IR/Instructions.h
@@ -1226,9 +1226,9 @@ class ICmpInst: public CmpInst {
     return {getSwappedPredicate(Pred), Pred.hasSameSign()};
   }
 
-  /// @returns the swapped predicate.
-  Predicate getSwappedCmpPredicate() const {
-    return getSwappedPredicate(getCmpPredicate());
+  /// @returns the swapped predicate along with samesign information.
+  CmpPredicate getSwappedCmpPredicate() const {
+    return getSwappedCmpPredicate(getCmpPredicate());
   }
 
   /// For example, EQ->EQ, SLE->SLE, UGT->SGT, etc.

Original file line number	Diff line number	Diff line change
`@@ -1226,9 +1226,9 @@ class ICmpInst: public CmpInst {`
`1226`	`1226`	`return {getSwappedPredicate(Pred), Pred.hasSameSign()};`
`1227`	`1227`	`}`
`1228`	`1228`
`1229`		`- /// @returns the swapped predicate.`
`1230`		`- Predicate getSwappedCmpPredicate() const {`
`1231`		`- return getSwappedPredicate(getCmpPredicate());`
	`1229`	`+ /// @returns the swapped predicate along with samesign information.`
	`1230`	`+ CmpPredicate getSwappedCmpPredicate() const {`
	`1231`	`+ return getSwappedCmpPredicate(getCmpPredicate());`
`1232`	`1232`	`}`
`1233`	`1233`
`1234`	`1234`	`/// For example, EQ->EQ, SLE->SLE, UGT->SGT, etc.`