fix nits

Author: Jinjie-Huang

clang/docs/ReleaseNotes.rst

@@ -405,7 +405,7 @@ Improvements to Clang's diagnostics
   attributes are used with a negative size (#GH165463).
 
 - A new warning ``-Wshadow-header`` has been added to detect when a header file
-  included via quotes (#include "...") is found in multiple distinct search directories.
+  is found in multiple search directories(excluding system paths).
 
 Improvements to Clang's time-trace
 ----------------------------------

clang/include/clang/Lex/HeaderSearch.h

@@ -465,7 +465,7 @@ class HeaderSearch {
     ExternalSource = ES;
   }
 
-  void DiagnoseHeaderShadowing(
+  void diagnoseHeaderShadowing(
       StringRef Filename, OptionalFileEntryRef FE, bool &DiagnosedShadowing,
       SourceLocation IncludeLoc, ConstSearchDirIterator FromDir,
       ArrayRef<std::pair<OptionalFileEntryRef, DirectoryEntryRef>> Includers,

clang/lib/Lex/HeaderSearch.cpp

@@ -881,7 +881,7 @@ diagnoseFrameworkInclude(DiagnosticsEngine &Diags, SourceLocation IncludeLoc,
         << IncludeFilename;
 }
 
-void HeaderSearch::DiagnoseHeaderShadowing(
+void HeaderSearch::diagnoseHeaderShadowing(
     StringRef Filename, OptionalFileEntryRef FE, bool &DiagnosedShadowing,
     SourceLocation IncludeLoc, ConstSearchDirIterator FromDir,
     ArrayRef<std::pair<OptionalFileEntryRef, DirectoryEntryRef>> Includers,
@@ -1024,7 +1024,7 @@ OptionalFileEntryRef HeaderSearch::LookupFile(
       if (OptionalFileEntryRef FE = getFileAndSuggestModule(
               TmpDir, IncludeLoc, IncluderAndDir.second, IncluderIsSystemHeader,
               RequestingModule, SuggestedModule)) {
-        DiagnoseHeaderShadowing(Filename, FE, DiagnosedShadowing, IncludeLoc,
+        diagnoseHeaderShadowing(Filename, FE, DiagnosedShadowing, IncludeLoc,
                                 FromDir, Includers, isAngled,
                                 &IncluderAndDir - Includers.begin(), nullptr);
         if (!Includer) {
@@ -1161,7 +1161,7 @@ OptionalFileEntryRef HeaderSearch::LookupFile(
     if (!File)
       continue;
 
-    DiagnoseHeaderShadowing(Filename, File, DiagnosedShadowing, IncludeLoc,
+    diagnoseHeaderShadowing(Filename, File, DiagnosedShadowing, IncludeLoc,
                             FromDir, Includers, isAngled, -1, It);
 
     CurDir = It;