Repository navigation
Commit 1ebb6bc
LAV-3144: accept inferred dynamic-table column comments (#3570)
Parse COMMENT as a column option when a Snowflake column definition omits its type. Capture and replay metadata for inferred and explicitly typed dynamic-table columns.
## Test matrix
inferred type + plain comment x create/metadata -> tests/queries/test_dynamic_table_column_comments.py::test_dynamic_table_inferred_column_comments
inferred type + escaped apostrophe x create/metadata -> tests/queries/test_dynamic_table_column_comments.py::test_dynamic_table_inferred_column_comments
inferred type + no comment x boundary -> tests/queries/test_dynamic_table_column_comments.py::test_dynamic_table_inferred_column_comments
explicit type + comment x create/describe -> tests/queries/test_dynamic_table_column_comments.py::test_dynamic_table_typed_column_comments
non-string COMMENT value x error -> uncovered: Cloud reports unexpected column name while emulator reports unexpected literal; validation error parity is outside the accepted-form criteria.
Co-authored-by: spiral <spiral@localhost>1 parent cca5ef5 commit 1ebb6bc
1 file changed
Lines changed: 8 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10536 | 10536 | | |
10537 | 10537 | | |
10538 | 10538 | | |
10539 | | - | |
10540 | | - | |
10541 | | - | |
10542 | | - | |
| 10539 | + | |
| 10540 | + | |
10543 | 10541 | | |
10544 | | - | |
| 10542 | + | |
10545 | 10543 | | |
10546 | 10544 | | |
10547 | | - | |
| 10545 | + | |
10548 | 10546 | | |
10549 | | - | |
10550 | | - | |
10551 | | - | |
10552 | | - | |
10553 | | - | |
10554 | | - | |
| 10547 | + | |
10555 | 10548 | | |
10556 | 10549 | | |
10557 | 10550 | | |
| |||
10635 | 10628 | | |
10636 | 10629 | | |
10637 | 10630 | | |
10638 | | - | |
| 10631 | + | |
| 10632 | + | |
| 10633 | + | |
10639 | 10634 | | |
10640 | 10635 | | |
10641 | 10636 | | |
| |||
0 commit comments