Skip to content

Commit 98f2c2b

Browse files
authored
Fix source links (#537)
* Fix source links * Fix README typo * Markdownlint * Fix waiting in the test action * Fix the version used by mike in the test action
1 parent a2fea40 commit 98f2c2b

File tree

11 files changed

+36
-25
lines changed

11 files changed

+36
-25
lines changed

.github/workflows/mkdocs-test.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,13 @@ jobs:
6767
mkdocs serve > /dev/null 2>&1 &
6868
SERVER_PID=$!
6969
echo "mk server in PID $SERVER_PID"
70-
# Give enough time for deployment
71-
sleep 30
70+
# Give enough time for deployment (2min max)
71+
for run in {1..120}; do
72+
if curl --output /dev/null --silent --head --fail http://127.0.0.1:8000/; then
73+
break
74+
fi
75+
sleep 1
76+
done
7277
echo "Launching linkchecker"
7378
linkchecker --no-warnings --no-status http://127.0.0.1:8000/
7479
@@ -81,4 +86,4 @@ jobs:
8186
git config --global user.email [email protected]
8287
8388
- name: Generate the docs with mike
84-
run: mike deploy 3.2-SNAPSHOT dev -u
89+
run: mike deploy test-version

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This is the source of the Hopsworks Documentation published at <https://docs.hop
44

55
## Build instructions
66

7-
We use `mkdocs` together with [`mike`]((https://github.com/jimporter/mike/) for versioning to build the documentation.
7+
We use `mkdocs` together with [`mike`](https://github.com/jimporter/mike/) for versioning to build the documentation.
88
We also use this two main mkdocs plugins: [`mkdocstrings`](https://mkdocstrings.github.io/) and [its Python handler](https://mkdocstrings.github.io/python/), and [`mkdocs-material`](https://squidfunk.github.io/mkdocs-material/) as the theme.
99

1010
**Background about `mike`:**

docs/setup_installation/admin/configure-project-mapping.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Configure group to project mapping
22

33
## Introduction
4+
45
A group-to-project mapping lets you automatically add all members of a Hopsworks group to a project, eliminating the need to add each user individually. To create a mapping, you simply select a Hopsworks group, choose the project it should be linked to, and assign the role that its members will have within that project.
56

67
Once a mapping is created, project membership is controlled through Hopsworks group membership. Any updates made to the Hopsworks group—such as adding or removing users—will automatically be reflected in the project membership. For example, if a user is removed from the Hopsworks group, they will also be removed from the corresponding project.
@@ -9,6 +10,7 @@ Once a mapping is created, project membership is controlled through Hopsworks gr
910

1011
1. Hopsworks group mapping sync enabled. This can be done by setting the variable ```hw_group_mapping_sync_enabled=true```.
1112
See [Cluster Configuration](./variables.md) on how to change variable values in Hopsworks.
13+
1214
<figure>
1315
<a href="../../../../assets/images/admin/project-mapping/configuration-variables.png">
1416
<img src="../../../../assets/images/admin/project-mapping/configuration-variables.png" alt="Enable Hopsworks mapping" />
@@ -26,9 +28,10 @@ If you can not find the variable ```hw_group_mapping_sync_enabled``` create it b
2628
</figure>
2729

2830
### Step 1: Create a mapping
31+
2932
To create a mapping go to **Cluster Settings** by clicking on your name in the top right
3033
corner of the navigation bar and choosing *Cluster Settings* from the dropdown menu.
31-
In the _Project mapping_ tab, you can create a new mapping by clicking on _Create new mapping_.
34+
In the *Project mapping* tab, you can create a new mapping by clicking on *Create new mapping*.
3235

3336
<figure>
3437
<a href="../../../../assets/images/admin/project-mapping/project-mapping-empty.png">
@@ -45,10 +48,10 @@ This will take you to the create mapping page shown below
4548
<figcaption>Create mapping</figcaption>
4649
</figure>
4750

48-
Here you can enter your Hopsworks group and map it to a project from the _Project_ drop down list.
49-
You can also choose the _Project role_ users will be assigned when they are added to the project.
51+
Here you can enter your Hopsworks group and map it to a project from the *Project* drop down list.
52+
You can also choose the *Project role* users will be assigned when they are added to the project.
5053

51-
Finally, click on _Create mapping_ and go back to mappings. You should see the newly created mapping(s) as shown below.
54+
Finally, click on *Create mapping* and go back to mappings. You should see the newly created mapping(s) as shown below.
5255

5356
<figure>
5457
<a href="../../../../assets/images/admin/project-mapping/group-to-project-mappings.png">
@@ -59,7 +62,7 @@ Finally, click on _Create mapping_ and go back to mappings. You should see the n
5962

6063
### Step 2: Edit a mapping
6164

62-
From the list of mappings click on the edit button (:material-pencil:). This will open a popup that will allow you to change the _group_, _project name_, and _project role_ of a mapping.
65+
From the list of mappings click on the edit button (:material-pencil:). This will open a popup that will allow you to change the *group*, *project name*, and *project role* of a mapping.
6366

6467
<figure>
6568
<a href="../../../../assets/images/admin/project-mapping/edit-hw-mapping.png">
@@ -69,11 +72,11 @@ From the list of mappings click on the edit button (:material-pencil:). This wil
6972
</figure>
7073

7174
!!!Warning
72-
Updating a mapping's _group_ or _project name_ will remove all members of the previous group from the project.
75+
Updating a mapping's *group* or *project name* will remove all members of the previous group from the project.
7376

7477
### Step 3: Delete a mapping
7578

7679
To delete a mapping click on the delete button.
7780

7881
!!!Warning
79-
Deleting a mapping will remove all members of that group from the project.
82+
Deleting a mapping will remove all members of that group from the project.

docs/setup_installation/admin/oauth2/configure-project-mapping.md

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
# Configure OAuth2 group to project mapping
22

33
## Introduction
4+
45
A group-to-project mapping lets you automatically add all members of an OAuth2 group to a project, eliminating the need to add each user individually. To create a mapping, you simply select an OAuth2 group, choose the project it should be linked to, and assign the role that its members will have within that project.
56

67
Once a mapping is created, project membership is controlled through OAuth2 group membership. Any updates made to the OAuth2 group—such as adding or removing users—will automatically be reflected in Hopsworks. For example, if a user is removed from the OAuth2 group, they will also be removed from the corresponding project.
78

89
## Prerequisites
10+
911
1. A server configured with OAuth2. See [Register Identity Provider in Hopsworks](./create-client.md) for instructions on how to do this.
1012
2. OAuth2 group mapping sync enabled. This can be done by setting the variable ```oauth_group_mapping_sync_enabled=true```.
1113
See [Cluster Configuration](../variables.md) on how to change variable values in Hopsworks.
14+
1215
<figure>
1316
<a href="../../../../assets/images/admin/project-mapping/configuration-variables.png">
1417
<img src="../../../../assets/images/admin/project-mapping/configuration-variables.png" alt="Enable OAuth2 mapping" />
@@ -26,9 +29,10 @@ If you can not find the variable ```oauth_group_mapping_sync_enabled``` create i
2629
</figure>
2730

2831
### Step 1: Create a mapping
32+
2933
To create a mapping go to **Cluster Settings** by clicking on your name in the top right
3034
corner of the navigation bar and choosing *Cluster Settings* from the dropdown menu.
31-
In the _Project mapping_ tab, you can create a new mapping by clicking on _Create new mapping_.
35+
In the *Project mapping* tab, you can create a new mapping by clicking on *Create new mapping*.
3236

3337
<figure>
3438
<a href="../../../../assets/images/admin/project-mapping/project-mapping-empty.png">
@@ -45,10 +49,10 @@ This will take you to the create mapping page shown below
4549
<figcaption>Create mapping</figcaption>
4650
</figure>
4751

48-
Here you can enter your OAuth2 group and map it to a project from the _Project_ drop down list.
49-
You can also choose the _Project role_ users will be assigned when they are added to the project.
52+
Here you can enter your OAuth2 group and map it to a project from the *Project* drop down list.
53+
You can also choose the *Project role* users will be assigned when they are added to the project.
5054

51-
Finally, click on _Create mapping_ and go back to mappings. You should see the newly created mapping(s) as shown below.
55+
Finally, click on *Create mapping* and go back to mappings. You should see the newly created mapping(s) as shown below.
5256

5357
<figure>
5458
<a href="../../../../assets/images/admin/project-mapping/group-to-project-mappings.png">
@@ -64,7 +68,7 @@ Finally, click on _Create mapping_ and go back to mappings. You should see the n
6468

6569
### Step 2: Edit a mapping
6670

67-
From the list of mappings click on the edit button (:material-pencil:). This will open a popup that will allow you to change the _remote group_, _project name_, and _project role_ of a mapping.
71+
From the list of mappings click on the edit button (:material-pencil:). This will open a popup that will allow you to change the *remote group*, *project name*, and *project role* of a mapping.
6872

6973
<figure>
7074
<a href="../../../../assets/images/admin/project-mapping/edit-mapping.png">
@@ -74,11 +78,11 @@ From the list of mappings click on the edit button (:material-pencil:). This wil
7478
</figure>
7579

7680
!!!Warning
77-
Updating a mapping's _remote group_ or _project name_ will remove all members of the previous group from the project.
81+
Updating a mapping's *remote group* or *project name* will remove all members of the previous group from the project.
7882

7983
### Step 3: Delete a mapping
8084

8185
To delete a mapping click on the delete button.
8286

8387
!!!Warning
84-
Deleting a mapping will remove all members of that group from the project.
88+
Deleting a mapping will remove all members of that group from the project.

docs/templates/python/material/attribute.html.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
{% block heading scoped %}
44
{% block source_link scoped %}
5-
{% if config.link_source and attribute.source_link %}
5+
{% if config.extra.link_source and attribute.source_link %}
66
<span style="float:right;font-size:.8rem;font-weight:400"><a href="{{ attribute.source_link }}">[source]</a></span>
77
{% endif %}
88
{% endblock source_link %}

docs/templates/python/material/class.html.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
{% block heading scoped %}
44
{% block source_link scoped %}
5-
{% if config.link_source and class.source_link %}
5+
{% if config.extra.link_source and class.source_link %}
66
<span style="float:right;font-size:.8rem;font-weight:400"><a href="{{ class.source_link }}">[source]</a></span>
77
{% endif %}
88
{% endblock source_link %}

docs/templates/python/material/function.html.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
{% block heading scoped %}
44
{% block source_link scoped %}
5-
{% if config.link_source and function.source_link %}
5+
{% if config.extra.link_source and function.source_link %}
66
<span style="float:right;font-size:.8rem;font-weight:400"><a href="{{ function.source_link }}">[source]</a></span>
77
{% endif %}
88
{% endblock source_link %}

docs/templates/python/material/module.html.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
{% block heading scoped %}
44
{% block source_link scoped %}
5-
{% if config.link_source and module.source_link %}
5+
{% if config.extra.link_source and module.source_link %}
66
<span style="float:right;font-size:.8rem;font-weight:400"><a href="{{ module.source_link }}">[source]</a></span>
77
{% endif %}
88
{% endblock source_link %}

docs/user_guides/projects/jobs/pyspark_job.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,6 @@ The following table describes the job configuration parameters for a PYSPARK job
251251
| <nobr>`conf['archives']`</nobr> | string | Comma-separated string of HDFS path(s) to archives to be made available to the application. Example: `hdfs:///Project/<project_name>/Resources/archive.zip,...` | `null` |
252252
| <nobr>`conf['properties']`</nobr> | string | A new line separated (`\n`) list of properties to pass to the Spark application. The properties should be in the format `name=value` | `null` |
253253

254-
255254
## Accessing project data
256255

257256
### Read directly from the filesystem (recommended)

docs/user_guides/projects/jobs/spark_job.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ The following table describes the job configuration parameters for a SPARK job.
253253
| <nobr>`conf['archives']`</nobr> | string | Comma-separated string of HDFS path(s) to archives to be made available to the application. Example: `hdfs:///Project/<project_name>/Resources/archive.zip,...` | `null` |
254254
| <nobr>`conf['properties']`</nobr> | string | A new line separated (`\n`) list of properties to pass to the Spark application. The properties should be in the format `name=value` | `null` |
255255

256-
257256
## Accessing project data
258257

259258
### Read directly from the filesystem (recommended)

0 commit comments

Comments
 (0)