Fix scroll in some Android devices #223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2017 20:08
Scrollify wasn't working in some Android Devices
|
Ah I didn't spot this, so I did the same thing although mine detects passive support, keeps existing options and makes sure the removeEventListener still works. |
Author
|
But that PR didn't build minified version. You should accept someone else, and close other. |
|
Building a minified version in pull a requests isn't very useful since virtually every pull request would cause a merge conflict. Like this one. :P |
Author
|
then Will you close this PR? |
|
It's not my project, I'm just some dude that sent a different PR. |
Author
|
ok |
Owner
|
Closing as it looks like these changes have made their way in via a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrollify was not working correctly in some Android Devices. So, I bring you the solution.