Allow the rewriter to be constructed separately from lps::explorer #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes lps::explorer and lts::state_space_generator now derive from lps::explorer_base and lts::state_space_generator_base. This is done to allow an existing rewriter to be reused for state space generation. This will be used to improve the efficiency of Dezyne workflows.
mlaveaux
reviewed
Nov 12, 2025
|
|
||
| explorer(const Specification& lpsspec, const explorer_options& options) | ||
| : holder_type(lpsspec, options) | ||
| , base_type(lpsspec, options, holder_type::m_global_rewr) |
Member
There was a problem hiding this comment.
Something I did not quite consider yesterday, but is there a concern with moving/copying the explorer with rewriter as this reference points to a member variable. It could be made non copyable I suppose, if that is an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes lps::explorer and lts::state_space_generator now derive from lps::explorer_base and lts::state_space_generator_base. This is done to allow an existing rewriter to be reused for state space generation. This will be used to improve the efficiency of Dezyne workflows.