Skip to content

Commit 05ab87b

Browse files
authored
Merge pull request #321 from RRosio/installed_packages
Default to display `installed` packages in environment's package list
2 parents bca68f5 + fd63599 commit 05ab87b

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

packages/common/src/components/CondaPkgPanel.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class CondaPkgPanel extends React.Component<
9898
packages: [],
9999
selected: [],
100100
searchTerm: '',
101-
activeFilter: PkgFilters.All
101+
activeFilter: PkgFilters.Installed
102102
};
103103

104104
this._model = this.props.packageManager;
@@ -308,7 +308,7 @@ export class CondaPkgPanel extends React.Component<
308308
this.setState({
309309
isApplyingChanges: false,
310310
selected: [],
311-
activeFilter: PkgFilters.All
311+
activeFilter: PkgFilters.Installed
312312
});
313313
this._updatePackages();
314314
}
@@ -342,7 +342,7 @@ export class CondaPkgPanel extends React.Component<
342342
this.setState({
343343
isApplyingChanges: false,
344344
selected: [],
345-
activeFilter: PkgFilters.All
345+
activeFilter: PkgFilters.Installed
346346
});
347347
this._updatePackages();
348348
}
@@ -390,9 +390,7 @@ export class CondaPkgPanel extends React.Component<
390390

391391
render(): JSX.Element {
392392
let filteredPkgs: Conda.IPackage[] = [];
393-
if (this.state.activeFilter === PkgFilters.All) {
394-
filteredPkgs = this.state.packages;
395-
} else if (this.state.activeFilter === PkgFilters.Installed) {
393+
if (this.state.activeFilter === PkgFilters.Installed) {
396394
filteredPkgs = this.state.packages.filter(pkg => pkg.version_installed);
397395
} else if (this.state.activeFilter === PkgFilters.Available) {
398396
filteredPkgs = this.state.packages.filter(pkg => !pkg.version_installed);

packages/common/src/components/CondaPkgToolBar.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { cartArrowDownIcon, externalLinkIcon, undoIcon } from '../icon';
88
export const PACKAGE_TOOLBAR_HEIGHT = 40;
99

1010
export enum PkgFilters {
11-
All = 'ALL',
1211
Installed = 'INSTALLED',
1312
Available = 'AVAILABLE',
1413
Updatable = 'UPDATABLE',
@@ -71,7 +70,6 @@ export const CondaPkgToolBar = (props: ICondaPkgToolBarProps): JSX.Element => {
7170
onChange={props.onCategoryChanged}
7271
aria-label="Package filter"
7372
>
74-
<option value={PkgFilters.All}>All</option>
7573
<option value={PkgFilters.Installed}>Installed</option>
7674
<option value={PkgFilters.Available}>Not installed</option>
7775
<option value={PkgFilters.Updatable}>Updatable</option>

0 commit comments

Comments
 (0)