Skip to content

Commit 1f02371

Browse files
committed
fix state coupling issue with default view and drawer view when modifying package versions
1 parent 8e0179d commit 1f02371

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

packages/common/src/components/CondaPkgDrawer.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ export interface ICondaPkgDrawerProps {
4343
* Package selection handler
4444
*/
4545
onPkgClick: (pkg: Conda.IPackage) => void;
46-
/**
47-
* Package version selection handler
48-
*/
49-
onPkgChange: (pkg: Conda.IPackage, version: string) => void;
5046
/**
5147
* Callback called when packages are installed successfully
5248
*/
@@ -93,7 +89,6 @@ export const CondaPkgDrawer: React.FunctionComponent<ICondaPkgDrawerProps> = (
9389
} else {
9490
setSelectedPackages(selectedPackages.filter(p => p !== pkg));
9591
}
96-
props.onPkgChange(pkg, version);
9792
};
9893

9994
const handlePackageSelection = (pkg: Conda.IPackage) => {

packages/common/src/components/CondaPkgPanel.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,6 @@ export class CondaPkgPanel extends React.Component<
491491
packages={uninstalledPkgs}
492492
isLoading={this.state.isLoading}
493493
onPkgClick={this.handleClick}
494-
onPkgChange={this.handleVersionSelection}
495494
onPkgGraph={this.handleDependenciesGraph}
496495
onClose={this.handleCloseDrawer}
497496
onPackagesInstalled={this.handlePackagesInstalled}

0 commit comments

Comments
 (0)