build: upgrade go to 1.20 (#111)

Author: rarkebauer

.github/workflows/lint.yaml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.19'
-      - uses: golangci/golangci-lint-action@v3.2.0
+          go-version: '1.20'
+      - uses: golangci/golangci-lint-action@v3.4.0
         with:
-          version: v1.50.0
+          version: v1.51.1

.github/workflows/test.yaml

@@ -19,7 +19,7 @@ jobs:
     steps:
     - uses: actions/setup-go@v2
       with:
-        go-version: '1.19'
+        go-version: '1.20'
 
     - uses: actions/checkout@v2
 
@@ -38,8 +38,8 @@ jobs:
     strategy:
       matrix:
         go_version:
+        - '1.19'
         - '1.18'
-        - '1.17'
 
     steps:
     - uses: actions/setup-go@v2

Dockerfile

@@ -1,5 +1,5 @@
 # syntax = docker/dockerfile:1.3
-FROM golang:1.19 AS build
+FROM golang:1.20 AS build
 
 WORKDIR /go/src/github.com/mccutchen/go-httpbin
 

httpbin/digest/digest.go

@@ -12,10 +12,10 @@ package digest
 
 import (
 	"crypto/md5"
+	crypto_rand "crypto/rand"
 	"crypto/sha256"
 	"crypto/subtle"
 	"fmt"
-	"math/rand"
 	"net/http"
 	"strings"
 	"time"
@@ -55,7 +55,7 @@ func Check(req *http.Request, username, password string) bool {
 // algorithm. If an invalid realm or an unsupported algorithm is given
 func Challenge(realm string, algorithm digestAlgorithm) string {
 	entropy := make([]byte, 32)
-	rand.Read(entropy)
+	crypto_rand.Read(entropy)
 
 	opaqueVal := entropy[:16]
 	nonceVal := fmt.Sprintf("%s:%x", time.Now(), entropy[16:31])

httpbin/handlers_test.go

@@ -91,7 +91,7 @@ func assertBodyEquals(t *testing.T, w *httptest.ResponseRecorder, want string) {
 }
 
 func randStringBytes(n int) string {
-	rand.Seed(time.Now().UnixNano())
+	rand.New(rand.NewSource(time.Now().UnixNano()))
 	b := make([]byte, n)
 	for i := range b {
 		b[i] = alphanumLetters[rand.Intn(len(alphanumLetters))]

httpbin/helpers.go

@@ -2,6 +2,7 @@ package httpbin
 
 import (
 	"bytes"
+	crypto_rand "crypto/rand"
 	"crypto/sha1"
 	"encoding/base64"
 	"encoding/json"
@@ -284,7 +285,7 @@ func sha1hash(input string) string {
 
 func uuidv4() string {
 	buff := make([]byte, 16)
-	_, err := rand.Read(buff[:])
+	_, err := crypto_rand.Read(buff[:])
 	if err != nil {
 		panic(err)
 	}