Skip to content

Commit 4f80b1e

Browse files
committed
Use designated Scala methods for converter utils
1 parent 8a009e0 commit 4f80b1e

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

http/src/main/scala/org/apache/pekko/http/javadsl/server/RoutingJavaMapping.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ private[http] object RoutingJavaMapping {
9999
// val javaToScalaResponseEntity extends Inherited[javadsl.model.ResponseEntity, scaladsl.model.ResponseEntity]
100100

101101
implicit final class ConvertCompletionStage[T](val stage: CompletionStage[T]) extends AnyVal {
102-
import pekko.util.FutureConverters
103-
def asScala = FutureConverters.asScala(stage)
102+
import pekko.util.FutureConverters._
103+
def asScala = CompletionStageOps(stage).asScala
104104
}
105105
}

http/src/main/scala/org/apache/pekko/http/javadsl/server/directives/BasicDirectives.scala

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ import java.util.function.Predicate
4848
import pekko.dispatch.ExecutionContexts
4949
import pekko.event.LoggingAdapter
5050
import pekko.http.javadsl.server
51-
import pekko.util.FutureConverters
5251
import pekko.util.FutureConverters._
5352

5453
import scala.concurrent.duration.FiniteDuration
@@ -98,8 +97,8 @@ abstract class BasicDirectives {
9897
def mapRouteResultFuture(f: JFunction[CompletionStage[RouteResult], CompletionStage[RouteResult]],
9998
inner: Supplier[Route]): Route = RouteAdapter {
10099
D.mapRouteResultFuture(stage =>
101-
FutureConverters.asScala(
102-
f(stage.fast.map(_.asJava)(ExecutionContexts.parasitic).asJava)).fast.map(_.asScala)(
100+
CompletionStageOps(
101+
f(stage.fast.map(_.asJava)(ExecutionContexts.parasitic).asJava)).asScala.fast.map(_.asScala)(
103102
ExecutionContexts.parasitic)) {
104103
inner.get.delegate
105104
}
@@ -108,15 +107,15 @@ abstract class BasicDirectives {
108107
def mapRouteResultWith(f: JFunction[RouteResult, CompletionStage[RouteResult]], inner: Supplier[Route]): Route =
109108
RouteAdapter {
110109
D.mapRouteResultWith(r =>
111-
FutureConverters.asScala(f(r.asJava)).fast.map(_.asScala)(ExecutionContexts.parasitic)) {
110+
CompletionStageOps(f(r.asJava)).asScala.fast.map(_.asScala)(ExecutionContexts.parasitic)) {
112111
inner.get.delegate
113112
}
114113
}
115114

116115
def mapRouteResultWithPF(
117116
f: PartialFunction[RouteResult, CompletionStage[RouteResult]], inner: Supplier[Route]): Route = RouteAdapter {
118117
D.mapRouteResultWith(r =>
119-
FutureConverters.asScala(f(r.asJava)).fast.map(_.asScala)(ExecutionContexts.parasitic)) {
118+
CompletionStageOps(f(r.asJava)).asScala.fast.map(_.asScala)(ExecutionContexts.parasitic)) {
120119
inner.get.delegate
121120
}
122121
}
@@ -174,7 +173,7 @@ abstract class BasicDirectives {
174173
def recoverRejectionsWith(
175174
f: JFunction[JIterable[Rejection], CompletionStage[RouteResult]], inner: Supplier[Route]): Route = RouteAdapter {
176175
D.recoverRejectionsWith(rs =>
177-
FutureConverters.asScala(f.apply(Util.javaArrayList(rs.map(_.asJava)))).fast.map(_.asScala)(
176+
CompletionStageOps(f.apply(Util.javaArrayList(rs.map(_.asJava)))).asScala.fast.map(_.asScala)(
178177
ExecutionContexts.parasitic)) { inner.get.delegate }
179178
}
180179

0 commit comments

Comments
 (0)