Feat request neighbours #3709
Draft
Feat request neighbours #3709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to figure out decoding - and I have differences between the debug panel and the display, and neither make sense
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3709 +/- ##
========================================
- Coverage 0.53% 0.52% -0.01%
========================================
Files 392 392
Lines 22940 23082 +142
Branches 2894 2920 +26
========================================
Hits 122 122
- Misses 22797 22939 +142
Partials 21 21 ☔ View full report in Codecov by Sentry. |
jamesarich
reviewed
Dec 6, 2025
| } | ||
| } | ||
|
|
||
| override fun requestNeighbourInfo(requestId: Int, destNum: Int) = toRemoteExceptions { |
Collaborator
There was a problem hiding this comment.
Neighbour or Neighbor - idrc, but we should align on one. 😂
Collaborator
Author
There was a problem hiding this comment.
Unfortunately I think the US got to protos first.
jamesarich
reviewed
Dec 6, 2025
Collaborator
Author
|
It also pops up on every Neighbour packet, or when one arrives while the app is closed. I need to fix that. Was hoping to test it on new FW, but then the new FW didn't play nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires meshtastic/firmware#8523
Adds a button to node details to request neighbours from a node.