Skip to content

Fix SHT41 sensor detection issue (#7522) #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix SHT41 sensor detection issue (#7522) #8702

wants to merge 6 commits into from
+19 −26

Conversation

@StrangePelaton
Copy link

@StrangePelaton StrangePelaton commented Nov 20, 2025 •
edited
Loading

  • Remove serial number validation in SHT4XSensor::initDevice to allow initialization of sensors with unrecognized serials
  • Add debug logging for I2C registers 0x7E and 0x89 in ScanI2CTwoWire for better troubleshooting
  • Increase I2C delay from 20ms to 50ms for reliable register reads

🤝 Attestations

  • [x ] I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@StrangePelaton
Fix SHT41 sensor detection issue (meshtastic#7522)
9e86acc 
- Remove serial number validation in SHT4XSensor::initDevice to allow initialization of sensors with unrecognized serials
- Add debug logging for I2C registers 0x7E and 0x89 in ScanI2CTwoWire for better troubleshooting
- Increase I2C delay from 20ms to 50ms for reliable register reads
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thebentern thebentern requested a review from Copilot November 20, 2025 23:08
Copilot AI reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot finished reviewing on behalf of thebentern November 20, 2025 23:39
@thebentern thebentern requested a review from Copilot November 21, 2025 02:50
Copilot finished reviewing on behalf of thebentern November 21, 2025 02:51
Copilot AI reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thebentern thebentern added the bugfix Pull request that fixes bugs label Nov 21, 2025
@thebentern thebentern changed the base branch from develop to master November 23, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

bugfix Pull request that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StrangePelaton @CLAassistant @thebentern