ci: add lintrunner for clang-format and pyre #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
d4l3k
force-pushed
the
d4l3k/lint
branch
3 times, most recently
from
692d576 to
1e14ec0
Compare
Contributor
|
thanks |
d4l3k
force-pushed
the
d4l3k/lint
branch
18 times, most recently
from
b15071a to
024b7f5
Compare
d4l3k
changed the title
d4l3k
force-pushed
the
d4l3k/lint
branch
3 times, most recently
from
1e05067 to
5b5297d
Compare
Summary: As titled. This allows users to run basic lint (clang-format and pyre for Python types) in OSS. This recently was an issue in #57 as OSS contributors can't see lint results. The adapters were largely copied from `pytorch/pytorch` and the versions+configs match fbcode. For CI, we skip building the backends and only build the torchcomms frontend to check the py/pyi files. Pull Request resolved: #60 Test Plan: ``` pip install -v -e '.[dev]' --no-build-isolation lintrunner init lintrunner --all-files ``` Reviewed By: amirafzali Differential Revision: D87880298 Pulled By: d4l3k
Member
Author
|
Failures seem unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. This allows users to run basic lint (clang-format and pyre for Python types) in OSS.
This recently was an issue in #57 as OSS contributors can't see lint results.
The adapters were largely copied from
pytorch/pytorchand the versions+configs match fbcode.For CI, we skip building the backends and only build the torchcomms frontend to check the py/pyi files.
Test plan: