feat: continue with integration of ct-remote: adapt to latest Nikola changes
#440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a changes re-enable some of the functionality; for now `cmdDelete` remains hidden: not sure we have it in the api; maybe not critical for now; also TODO: disable or adapt welcome-screen related code
alehander92
added
enhancement
very easy because of the feature flag: thanks to Nedy for implementing it and Zahary for pushing us to have feature flags!
alehander92
force-pushed
the
feat-continue-ct-remote-integration
branch
2 times, most recently
from
dff6814 to
c340059
Compare
…pting ct remote help this way it will show e.g. `ct remote login` instead of `desktopclient login` in its help add `CODETRACER_DEBUG_CT_REMOTE` env var for debugging/seeing cmd for ct remote
… same as `ct-remote`
alehander92
force-pushed
the
feat-continue-ct-remote-integration
branch
from
c340059 to
182e928
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-enable some of the functionality; for now
cmdDeleteremains hidden: not sure we have it in the api; maybe not critical for now;also fix: for now hide trace sharing from welcome screen until we have a clear idea of how to adapt it to current api; (but keep enabled for CLI); i expected this to be tedious, but it was very easy because of the feature flag: thanks to @pxor for implementing it and to @zah for pushing us to use feature flags!