Skip to content

Commit 3d60107

Browse files
karthiknadigCopilot
andcommitted
fix: clarify maintainer verification gates (PR #486)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent ce1e7da commit 3d60107

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/agents/Maintainer.agent.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ If `github/request_copilot_review` is unavailable, use the requested-reviewers A
236236
```powershell
237237
$body = @{ reviewers = @("copilot-pull-request-reviewer[bot]") } | ConvertTo-Json -Compress
238238
$body | gh api --method POST repos/OWNER/REPO/pulls/N/requested_reviewers --input -
239-
gh api repos/OWNER/REPO/pulls/N/requested_reviewers --jq '.users[].login'
239+
gh api repos/OWNER/REPO/pulls/N/requested_reviewers --jq '.users[] | select(.login == "Copilot") | .login'
240240
```
241241

242242
The verification output must include `Copilot` before entering the review polling loop.
@@ -332,7 +332,7 @@ Once review is complete and all checks pass:
332332

333333
Skip `git push origin --delete <branch>` if GitHub already auto-deleted the remote branch.
334334

335-
3. **Verify the merge postcondition:** Query the PR after requesting merge or auto-merge. Do not treat a zero exit code as sufficient; require `state: MERGED`, or a populated auto-merge request when required checks are still pending.
335+
3. **Verify the merge postcondition:** Run `gh pr view N --json state,mergedAt,autoMergeRequest` after requesting merge or auto-merge. Do not treat a zero exit code as sufficient; require `state` to be `MERGED` with `mergedAt` populated, or `autoMergeRequest` to be populated when required checks are still pending.
336336

337337
4. **CI triggers:** Push to main runs the full CI pipeline (builds, tests, artifact uploads).
338338

0 commit comments

Comments
 (0)