Skip to content

Fix contentprovider-sample, #287 #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix contentprovider-sample, #287 #1167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b6c796
Fixed
lthibideau Apr 3, 2025
6b4abed
Fixed
lthibideau Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions contentprovider-sample/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,20 @@ export default class Provider implements vscode.TextDocumentContentProvider, vsc
private _subscriptions: vscode.Disposable;

constructor() {

// Listen to the `closeTextDocument`-event which means we must
// clear the corresponding model object - `ReferencesDocument`
this._subscriptions = vscode.workspace.onDidCloseTextDocument(doc => this._documents.delete(doc.uri.toString()));
this._subscriptions = vscode.Disposable.from(
// Listen to the `closeTextDocument`-event which means we must
// clear the corresponding model object - `ReferencesDocument`
vscode.workspace.onDidCloseTextDocument(doc => this._documents.delete(doc.uri.toString())),

// This is necessary due to a race in ExtHostDocumentContentProvider where
// the onDidChange event may be triggered before the new document has been
// registered with ExtHostDocumentsAndEditors
vscode.workspace.onDidOpenTextDocument(doc => {
if (doc.uri.scheme === Provider.scheme) {
this._onDidChange.fire(doc.uri);
}
})
);
}

dispose() {
Expand Down