Skip to content

Commit f7c1a92

Browse files
Jaggernaut555jpwilliams
authored andcommitted
breaking: Change to websocket v5 (#22)
* fix: gitignore now ignores the correct build directory and .midiMixerPlugin files * fix: Updated midi-mixer-cli/plugin packages and added bundledDependencies to properly pack * fix: remove cached tracked output file * feat: Upgrade to websocket version 5 BREAKING CHANGE: Updated package not compatible with websocket version 4.x * feat: Add audio meters * remove test code * docs: Update PAGE.md indicating websocket v5 * fix: prepend 'ws://' if address does not start with it * fix: duh, wrong operator * Add scaling value for meters * remove simple attempt at retrying on connection failed
1 parent 85ed500 commit f7c1a92

File tree

5 files changed

+232
-120
lines changed

5 files changed

+232
-120
lines changed

PAGE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
## This Requires the OBS Websocket version 5
2+
13
# OBS Plugin
24

35
A proof-of-concept plugin that provides very basic OBS integration.

package-lock.json

Lines changed: 100 additions & 56 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
},
3636
"dependencies": {
3737
"midi-mixer-plugin": "^1.0.2",
38-
"obs-websocket-js": "^4.0.2",
38+
"obs-websocket-js": "^5.0.2",
3939
"ws": "8.4.0"
4040
},
4141
"bundledDependencies": [
@@ -45,7 +45,12 @@
4545
],
4646
"volta": {
4747
"node": "14.15.4",
48-
"npm": "6.14.11"
48+
"npm": "8.19.2"
4949
},
50-
"version": "0.1.6"
50+
"version": "0.1.6",
51+
"bundleDependencies": [
52+
"midi-mixer-plugin",
53+
"obs-websocket-js",
54+
"ws"
55+
]
5156
}

plugin.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"label": "OBS WebSocket Address",
1313
"required": false,
1414
"type": "text",
15-
"fallback": "localhost:4444"
15+
"fallback": "ws://localhost:4455"
1616
},
1717
"password": {
1818
"label": "OBS WebSocket Password",
@@ -27,6 +27,11 @@
2727
"reconnect": {
2828
"label": "Reconnect",
2929
"type": "button"
30+
},
31+
"meterMultiplier": {
32+
"label": "Meter Scaling Multiplier",
33+
"type": "text",
34+
"fallback": "1"
3035
}
3136
}
3237
}

0 commit comments

Comments
 (0)