Bugfix: this.validator.input[req] was changed to req, #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in after, after_or_equal, before, before_or_equal rules, as req is not the key of the input, but already the value to be validated.
…r_equal validation rules. date validity should be checked with date validation rule
…_equal rules again but letting it pass with return true now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in after, after_or_equal, before, before_or_equal rules, as req
is not the key of the input, but already the value to be validated.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
this.validator.input[req] was changed to req,
in after, after_or_equal, before, before_or_equal rules, as req
is not the key of the input, but already the value to be validated.
Which issue (if any) does this pull request address?
none
Is there anything you'd like reviewers to focus on?
I guess this was overlooked when processing the pull request that added these rules as a new feature. Is this package still actively maintained?