Align Distribution Balance#46
Draft
jhb10c wants to merge 2 commits into
Draft
Conversation
pdobacz
approved these changes
May 19, 2026
Collaborator
pdobacz
left a comment
pdobacz
left a comment
There was a problem hiding this comment.
Not going diving deep into protocol aspects, but update LGTM, some editorial nits
| @@ -46,13 +46,33 @@ class distribution_account: | |||
|
|
|||
| # This function is only callable via execution; no transaction can call it. | |||
| def syscall_distribute(address block_leader): | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| def syscall_distribute(address block_leader): | |
| def distribute(address block_leader): |
still says syscall_distribute is this intended?
| # 3. Get relevant validator info | ||
| val_execution = val_execution(val_id) | ||
| val_consensus = val_consensus(val_id) | ||
| auth = delegator(val_id,val_execution.auth_address) |
Collaborator
There was a problem hiding this comment.
Suggested change
| auth = delegator(val_id,val_execution.auth_address) | |
| auth = delegator(val_id, val_execution.auth_address) |
|
|
||
| # 4. Get Commission Fee if applicable | ||
| commission_amount = 0 | ||
| distribute_amount = 0 |
Collaborator
There was a problem hiding this comment.
this initialization seem unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align langauge of MIP with implementation. More generally balance is awarded automatically instead of just priority fees.