Avoid exception and console error message when SKCanvasView is created and then immediately disposed in Blazor #3427
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and then immediately disposed. In javascript methods, return earlier when element is not available in DOM, also remove the error message in same scenario. In Balazor, the elements are removed from DOM before calling Dispose() of the component. So after each async method, the DOM element may be removed due to navigate to other node. No simple way to detect if the missing element is because the component is disposed, or software logic error. Ref: dotnet/aspnetcore#45777
Contributor
|
Hey there @@jjzhang12! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jjzhang12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In JavaScript methods, return early when the target element is no longer present in the DOM, and remove the related error log for this scenario.
In Blazor, elements can be removed from the DOM before a component’s Dispose() method is invoked. This means that after any async call, the corresponding DOM element may already have been removed due to navigation. There’s no reliable way to distinguish whether a missing element is due to normal component disposal or an actual logic error. This change updates the code to simply stop execution when the element is absent and suppress error logging for this case.
Ref: dotnet/aspnetcore#45777
Bugs Fixed
#3322
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist