Merge pull request #7015 from escattone/improve-question-details-2623

fix N+1 query issue in `question.details`

Author: akatsoulas

kitsune/questions/jinja2/questions/question_details.html

@@ -396,7 +396,6 @@ <h3 class="sumo-card-heading">{{ _('Post a Reply') }}</h3>
       <li class="sidebar-subheading sidebar-nav--heading-item">{{ _('Tags') }}</li>
       <li id="tags-list">
         <div class="folder">
-          {% set tags = question.my_tags %}
           {% if tags or can_tag %}
             <div class="sidebox tight cf" id="tags">
               <div class="tags"{% if can_tag %} data-tag-vocab-json="{{ tag_vocab() }}"{% endif %}>
@@ -413,7 +412,7 @@ <h3 class="sumo-card-heading">{{ _('Post a Reply') }}</h3>
                         {% for tag in all_tags %}
                           <option value="{{ tag.id }}"
                                   data-url="{{ url('questions.list', product.slug if product else 'all')|urlparams(tagged=tag.slug) }}"
-                                  {% if tag in question.tags.all() %}selected{% endif %}>
+                                  {% if tag.id in tag_ids %}selected{% endif %}>
                             {{ tag.name }}
                           </option>
                         {% endfor %}

kitsune/questions/views.py

@@ -1547,6 +1547,9 @@ def _answers_data(request, question_id, form=None, watch_form=None, answer_previ
         QuestionReplyEvent.is_notifying(request.user, question)
         or QuestionSolvedEvent.is_notifying(request.user, question)
     )
+
+    tags = question.my_tags
+
     return {
         "question": question,
         "product": question.product,
@@ -1558,6 +1561,8 @@ def _answers_data(request, question_id, form=None, watch_form=None, answer_previ
         "feeds": feed_urls,
         "frequencies": frequencies,
         "is_watching_question": is_watching_question,
+        "tags": tags,
+        "tag_ids": {t.id for t in tags},
         "can_tag": request.user.has_perm("questions.tag_question"),
         "can_create_tags": request.user.has_perm("taggit.add_tag"),
     }