Skip to content

Pass progress to plugin scanner#19

Open
grliszas14 wants to merge 1 commit into
musescore:mainfrom
grliszas14:plugin_scanner
Open

Pass progress to plugin scanner#19
grliszas14 wants to merge 1 commit into
musescore:mainfrom
grliszas14:plugin_scanner

Conversation

@grliszas14
Copy link
Copy Markdown
Contributor

Resolves: audacity/audacity#10719

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@grliszas14
Copy link
Copy Markdown
Contributor Author

/build

}

PluginScanResult RegisterAudioPluginsScenario::scanPlugins() const
PluginScanResult RegisterAudioPluginsScenario::scanPlugins(muse::Progress* progress) const
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: is the muse:: prefix wanted, since we're already in that namespace? (I don't dislike it, but wanted to point it out. I leave it up to you.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom plugin locations

2 participants