polylineplot with relaxed y-clamping#25
Merged
saintmatthieu merged 1 commit intoMay 13, 2026
Merged
Conversation
Contributor
Author
|
/build |
Contributor
Author
|
@mathesoncalum and @kryksyh as reviewers please |
Collaborator
|
/build |
|
Build dispatched: https://github.com/musescore/muse_framework/actions/runs/25788578143 |
mathesoncalum
approved these changes
May 13, 2026
grliszas14
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for audacity/audacity#10223
This effect seems to be the first use-case where points have to be rendered offscreen - observe in the screenshot how the line at x=0 is below the bottom edge.
FWIW, I manually tested after my changes the two other places where these are used: Audacity's and MSS's volume automations. I couldn't find a regression there.
Build configuration
audacity: saintmatthieu/audacity/10223-port-filter-curve-eq
audacity platforms: linux_x64
musescore: saintmatthieu/MuseScore/polylineplot-with-relaxed-y-clamping
musescore platforms: linux_x64