Skip to content

polylineplot with relaxed y-clamping#25

Merged
saintmatthieu merged 1 commit into
musescore:mainfrom
saintmatthieu:polylineplot-with-relaxed-y-clamping
May 13, 2026
Merged

polylineplot with relaxed y-clamping#25
saintmatthieu merged 1 commit into
musescore:mainfrom
saintmatthieu:polylineplot-with-relaxed-y-clamping

Conversation

@saintmatthieu
Copy link
Copy Markdown
Contributor

@saintmatthieu saintmatthieu commented May 12, 2026

Needed for audacity/audacity#10223

image

This effect seems to be the first use-case where points have to be rendered offscreen - observe in the screenshot how the line at x=0 is below the bottom edge.

FWIW, I manually tested after my changes the two other places where these are used: Audacity's and MSS's volume automations. I couldn't find a regression there.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Build configuration

audacity: saintmatthieu/audacity/10223-port-filter-curve-eq
audacity platforms: linux_x64
musescore: saintmatthieu/MuseScore/polylineplot-with-relaxed-y-clamping
musescore platforms: linux_x64

@saintmatthieu saintmatthieu marked this pull request as ready for review May 13, 2026 08:43
@saintmatthieu
Copy link
Copy Markdown
Contributor Author

/build

@saintmatthieu
Copy link
Copy Markdown
Contributor Author

@mathesoncalum and @kryksyh as reviewers please

@kryksyh
Copy link
Copy Markdown
Collaborator

kryksyh commented May 13, 2026

/build

@github-actions
Copy link
Copy Markdown

@saintmatthieu saintmatthieu requested a review from grliszas14 May 13, 2026 11:42
@saintmatthieu saintmatthieu merged commit 4ae9f3e into musescore:main May 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants