Merge branch 'tiago/audit-todos' (#3234)

* origin/tiago/audit-todos:
  Changelog for #3234
  Audit TODOs in codebase

Author: brentstone

.changelog/unreleased/improvements/3234-audit-todos.md

@@ -0,0 +1,2 @@
+- Audit TODOs in the codebase.
+  ([\#3234](https://github.com/anoma/namada/pull/3234))

crates/apps_lib/src/cli.rs

@@ -3411,7 +3411,6 @@ pub mod args {
 
     #[derive(Clone, Debug)]
     pub struct LedgerDumpDb {
-        // TODO: allow to specify height
         pub block_height: Option<BlockHeight>,
         pub out_file_path: PathBuf,
         pub historic: bool,

crates/apps_lib/src/cli/api.rs

@@ -3,6 +3,7 @@ use namada::tendermint_rpc::HttpClient;
 use namada_sdk::error::Error;
 use namada_sdk::queries::Client;
 use namada_sdk::rpc::wait_until_node_is_synched;
+use tendermint_rpc::client::CompatMode;
 use tendermint_rpc::Url as TendermintUrl;
 
 /// Trait for clients that can be used with the CLI.
@@ -18,7 +19,11 @@ pub trait CliClient: Client + Sync {
 #[async_trait::async_trait(?Send)]
 impl CliClient for HttpClient {
     fn from_tendermint_address(address: &TendermintUrl) -> Self {
-        HttpClient::new(address.clone()).unwrap()
+        HttpClient::builder(address.clone().try_into().unwrap())
+            .compat_mode(CompatMode::V0_37)
+            .timeout(std::time::Duration::from_secs(30))
+            .build()
+            .unwrap()
     }
 
     async fn wait_until_node_is_synced(

crates/apps_lib/src/cli/client.rs

@@ -27,7 +27,6 @@ impl CliApi {
                 match cmd {
                     // Ledger cmds
                     Sub::TxCustom(TxCustom(args)) => {
-                        // TODO: too much boilerplate to setup client
                         let chain_ctx = ctx.borrow_mut_chain_or_exit();
                         let ledger_address =
                             chain_ctx.get(&args.tx.ledger_address);

crates/apps_lib/src/cli/utils.rs

@@ -20,7 +20,7 @@ use crate::cli::context::FromContext;
 
 /// Environment variable where Ethereum relayer private
 /// keys are stored.
-// TODO: remove this in favor of getting eth keys from
+// TODO(namada#2029): remove this in favor of getting eth keys from
 // namadaw, ledger, or something more secure
 #[cfg_attr(not(feature = "namada-eth-bridge"), allow(dead_code))]
 const RELAYER_KEY_ENV_VAR: &str = "NAMADA_RELAYER_KEY";

crates/apps_lib/src/client/rpc.rs

@@ -1046,13 +1046,20 @@ pub async fn query_bonded_stake<N: Namada>(
                 get_validator_stake(context.client(), epoch, &validator).await;
             match stake {
                 Some(stake) => {
-                    // TODO: show if it's in consensus set, below capacity, or
-                    // below threshold set
                     display_line!(
                         context.io(),
                         "Bonded stake of validator {validator}: {}",
                         stake.to_string_native()
+                    );
+                    query_and_print_validator_state(
+                        context,
+                        args::QueryValidatorState {
+                            query: args.query,
+                            validator,
+                            epoch: args.epoch,
+                        },
                     )
+                    .await;
                 }
                 None => {
                     display_line!(

crates/apps_lib/src/config/genesis.rs

@@ -598,7 +598,6 @@ pub mod tests {
         let (protocol_keypair, _eth_hot_bridge_keypair) =
             wallet::defaults::validator_keys();
 
-        // TODO: derive validator eth address from an eth keypair
         let eth_cold_gov_keypair: common::SecretKey =
             secp256k1::SigScheme::generate(&mut rng)
                 .try_to_sk()

crates/apps_lib/src/config/genesis/templates.rs

@@ -263,10 +263,10 @@ pub struct ChainParams<T: TemplateValidation> {
     /// Enable the native token transfer if it is true
     pub is_native_token_transferable: bool,
     /// Minimum number of blocks per epoch.
-    // TODO: u64 only works with values up to i64::MAX with toml-rs!
+    // NB: u64 only works with values up to i64::MAX with toml-rs!
     pub min_num_of_blocks: u64,
     /// Maximum duration per block (in seconds).
-    // TODO: this is i64 because datetime wants it
+    // NB: this is i64 because datetime wants it
     pub max_expected_time_per_block: i64,
     /// Max payload size, in bytes, for a tx batch proposal.
     ///

crates/apps_lib/src/config/genesis/transactions.rs

@@ -591,7 +591,7 @@ pub type SignedBondTx<T> = Signed<BondTx<T>>;
 pub struct ValidatorAccountTx<PK: Ord> {
     /// The address of the validator.
     pub address: StringEncoded<EstablishedAddress>,
-    // TODO: remove the vp field
+    // TODO(namada#2554): remove the vp field
     pub vp: String,
     /// Commission rate charged on rewards for delegators (bounded inside
     /// 0-1)

crates/apps_lib/src/config/mod.rs

@@ -364,9 +364,8 @@ And this is correct
     }
 "#;
 
-// TODO: Replaced `block_sync` and `blocksync`
-// with `fast_sync` and `fastsync`
-// due to https://github.com/informalsystems/tendermint-rs/issues/1368
+// TODO(informalsystems/tendermint-rs#1368): Replaced
+// `block_sync` and `blocksync` with `fast_sync` and `fastsync`
 pub const DEFAULT_COMETBFT_CONFIG: &str = r#"
 
 # This is a TOML config file.