Skip to content

Conversation

@6unYoung
Copy link

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • to_write ๋ณ€์ˆ˜๋ฅผ ์‚ญ์ œํ•˜๊ณ  ptr->flags.buffer_requests๋ฅผ ์ง์ ‘ ์‚ฌ์šฉํ•˜๊ฒŒ ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ธฐ์กด์—๋Š” to_write= not ptr->flags.buffer_requests;๋กœ ํ• ๋‹นํ•˜๊ณ , ์‚ฌ์šฉ ์‹œ์—๋Š” to_write == false๋ฅผ ๋น„๊ตํ•ด ์ด์ค‘ ๋ถ€์ •์ด ๋˜๋ฉฐ ๊ฐ€๋…์„ฑ์ด ๋‹ค์†Œ ๋–จ์–ด์กŒ๊ธฐ ๋•Œ๋ฌธ์ž…๋‹ˆ๋‹ค.

  • noreply ๋ณ€์ˆ˜๋ฅผ ์‚ญ์ œํ•˜๊ณ  ptr->flags.no_reply๋ฅผ ์ง์ ‘ ์‚ฌ์šฉํ•˜๊ฒŒ ํ†ต์ผํ–ˆ์Šต๋‹ˆ๋‹ค.

  • buffer_request, no_reply์ธ ๊ฒฝ์šฐ rc๊ฐ’ ๋ณ€๊ฒฝ ๋Œ€์‹  early return ํ•˜๋„๋ก ํ†ต์ผํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‹จ, ๊ธฐ์กด ๋ฐฉ์‹์ด ๋” ์ ํ•ฉํ•œ ๊ฒฝ์šฐ ๊ธฐ์กด ๋ฐฉ์‹์„ ์ฑ„ํƒํ–ˆ์Šต๋‹ˆ๋‹ค.

@6unYoung 6unYoung force-pushed the cleanup_calling_func_for_memcached_vdo branch from 4b1fa91 to f724192 Compare November 12, 2025 05:06
@6unYoung 6unYoung force-pushed the cleanup_calling_func_for_memcached_vdo branch from f724192 to d9c9fc8 Compare November 12, 2025 05:23
@ing-eoking ing-eoking self-requested a review November 12, 2025 05:43
@jhpark816 jhpark816 merged commit e6fdac7 into naver:develop Nov 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants