Scikit-learn version management for specific example scripts #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equirement of ncpi package is now scikit-learn==1.5.0. Only LFP and EEG scripts include this check.
laurator
changed the title
AlejandroOrozcoValero
approved these changes
Oct 28, 2025
Contributor
AlejandroOrozcoValero
left a comment
AlejandroOrozcoValero
left a comment
There was a problem hiding this comment.
I have tested the changes and confirmed that they work as expected. The automatic version management successfully installs scikit-learn 1.3.2 for both example scripts.
Extended ensure_module to handle the installation of a previous version of an already installed package. This eliminates the need for the specialized function for scikit-learn module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatic scikit-learn version management for LFP_developing_brain.py and EEG_AD.py scripts to ensure compatibility with version 1.3.2.
Changes
Impact
Ensures consistent model behavior and reproducibility for these specific example scripts that require scikit-learn 1.3.2 for compatibility with trained models and feature processing.
Testing
To test if this new version of the code works, it's necessary to do
pip install .in the /ncpi folder. The changes of this pull request only affect EEG_AD and LFP_developing_brain examples.