-
Notifications
You must be signed in to change notification settings - Fork 196
Bump and fix errors for release 2025.06 #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| //recurse on each partition | ||
| for (List<NodeWithEnvelope> partition : partitions) { | ||
| System.out.println("partition = " + partition); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove System.out.println
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
server-plugin/pom.xml
Outdated
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <version>2.13.1</version> | ||
| <version>2.11.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why downgrading this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't remember how it happened. I probably took it from here by mistake.
I reset it as actually it's not needed.
|
@Andy2003 I signed the CLA, thanks |
|
The changes of this PR are already included into the current main branch |
Bump and fix errors for release 2025.06
Tests executed
Additional infos
There are 4 tests that (locally) fail with StackOverflowError.
The strange thing is that they fail also if i execute them using the 5.26.0 / 5.20.0 tags,
and that they don't fail in the CI as we can see here.
Instead locally, using the same command and jdk (i.e.
jdk: 17.0.15-temand./mvnw --no-transfer-progress clean compile test -Dtest=RTreeBulkInsertTest) they fail.Moreover, by adding the maxNodeReference to 20 (i.e. the 3rd parameter here),
they are executed correctly.
Therefore i'm not sure if it's a bug or something strange that i have locally or some particular CI config that i don't have locally,
but i think we can skip them since the jar seems to be generated correctly and they are green in the CI.