Skip to content

refactor(thumbnails): simplify doThumbnailFromOCFileInBackground logic #15975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alperozturk96 merged 1 commit into from
Nov 26, 2025
Merged

refactor(thumbnails): simplify doThumbnailFromOCFileInBackground logic #15975

alperozturk96 merged 1 commit into from
Nov 26, 2025

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 17, 2025 •
edited
Loading

  • Tests written, or not not needed

Changes

  • Uses try-with-resources for safer InputStream handling
  • Improves logging for easier debugging
  • Introduces early returns to reduce nesting and simplify control flow
  • Adds null check for handlePNG function calls.

@tobiasKaminsky tobiasKaminsky force-pushed the simplify-do-thumbnail-from-oc-file-in-background branch from e794cc4 to f63d800 Compare November 26, 2025 09:13
@alperozturk96 alperozturk96 force-pushed the simplify-do-thumbnail-from-oc-file-in-background branch from f63d800 to fbcb45d Compare November 26, 2025 10:41
@alperozturk96 alperozturk96 force-pushed the simplify-do-thumbnail-from-oc-file-in-background branch from fbcb45d to e439312 Compare November 26, 2025 11:11
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Codacy

SpotBugs

SpotBugs increased!

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15975-Unit-test-11-18

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15975.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit 128ac02 into master Nov 26, 2025
12 of 20 checks passed
@alperozturk96 alperozturk96 deleted the simplify-do-thumbnail-from-oc-file-in-background branch November 26, 2025 12:06
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.0 milestone Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.35.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @tobiasKaminsky