Skip to content

Update Cram tests#1998

Merged
joverlee521 merged 1 commit into
masterfrom
update-cram-tmp
May 19, 2026
Merged

Update Cram tests#1998
joverlee521 merged 1 commit into
masterfrom
update-cram-tmp

Conversation

@joverlee521
Copy link
Copy Markdown
Contributor

@joverlee521 joverlee521 commented May 15, 2026

Description of proposed changes

Use default temp directory in Cram tests for ancestral, measurements, parse, titers, and traits.

I did this mostly because the use of the custom temp directory would cause tests to fail in the pytest-prysk test runs, but this is also part of effort to reorganize functional test files described in #1176.

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (031d40d) to head (197a131).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1998   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files          85       85           
  Lines       10728    10728           
  Branches     2100     2100           
=======================================
  Hits         7825     7825           
  Misses       2537     2537           
  Partials      366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joverlee521 joverlee521 force-pushed the update-cram-tmp branch 2 times, most recently from af6cea0 to 591a914 Compare May 19, 2026 18:55
Copy link
Copy Markdown
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Comment thread tests/functional/measurements_export.t Outdated
Comment thread tests/functional/measurements_concat.t
Use default temp directory in Cram tests for ancestral, measurements,
parse, titers, and traits.

I did this mostly because the use of the custom temp directory would
cause tests to fail in the pytest-prysk test runs, but this is also part
of effort to reorganize functional test files described in
<#1176>.
@joverlee521 joverlee521 merged commit 49c83b7 into master May 19, 2026
34 checks passed
@joverlee521 joverlee521 deleted the update-cram-tmp branch May 19, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants