Fix more packages. workingStackageExecutables builds on top of nixos-23.05.

Only minimal patches are put on top of the `nixos-23.05` branch to
support more of Stackage. All have nixpkgs PRs.

    nix-build --no-link survey/default.nix -A workingStackageExecutables | wc -l
    368

Author: nh2

README.md

@@ -104,6 +104,12 @@ Until Stack 2.3, the official static build of `stack` itself was built using thi
 The [`static-stack`](./static-stack) directory shows how Stack itself can be built statically with static-haskell-nix.
 `stack` is a big package with many dependencies, demonstrating that it works also for large projects.
 
+## Related important open issues
+
+You can contribute to these to help static Haskell executables:
+
+* https://github.com/haskell/cabal/issues/8455
+
 ## FAQ
 
 * I get `cannot find section .dynamic`. Is this an error?
@@ -116,6 +122,13 @@ The [`static-stack`](./static-stack) directory shows how Stack itself can be bui
     then `/nix/store/dax3wjbjfrcwj6r3mafxj5fx6wcg5zbp-stack-2.3.0.1` is your final output _store path_ whose `/bin` directory contains your static executable.
 * I get `stack2nix: user error (No such package mypackage-1.2.3 in the cabal database. Did you run cabal update?)`.
   * You most likely have to bump the date like `hackageSnapshot = "2019-05-08T00:00:00Z";` to a newer date (past the time that package-version was added to Hackage).
+* I get a linker error.
+  What's a good way to investigate what the linker invocation is?
+  * Pass `-v` to Cabal, and to GHC itself:
+    ```sh
+    nix-build --expr '(import ./survey/default.nix {}).haskellPackages.YOURPACKAGE.overrideAttrs (old: { configureFlags = (old.configureFlags or []) ++ ["-v" "--ghc-options=-v"]; })'
+    ```
+    Look for `*** Linker:` in the GHC output.
 * Can I build Stack projects with resolvers that are too old to be supported by Stack >= 2?
   * No. For that you need need to use an old `static-haskell-nix` version: The one before [this PR](https://github.com/nh2/static-haskell-nix/pull/98) was merged.
 * I get some other error. Can I just file an issue and have you help me with it?

nixpkgs

@@ -719,6 +719,9 @@ let
 
     openblas = (previous.openblas.override { enableStatic = true; });
 
+    libusb1 = previous.libusb1.override { withStatic = true; enableUdev = false; };
+    libusb-compat-0_1 = previous.libusb-compat-0_1.overrideAttrs (old: { dontDisableStatic = true; });
+
     openssl = previous.openssl.override { static = true; };
 
     zstd = previous.zstd.override { enableStatic = true; };
@@ -737,14 +740,35 @@ let
       staticOnly = true;
     };
 
-    # Brotli can currently build only static or shared libraries,
-    # see https://github.com/google/brotli/pull/655#issuecomment-864395830
-    brotli = previous.brotli.override { staticOnly = true; };
+    # For unclear reasons, brotli builds its `.a` files by default, but adds a `-static`
+    # infix to their names:
+    #
+    #     libbrotlicommon-static.a
+    #     libbrotlidec-static.a
+    #     libbrotlienc-static.a
+    #
+    # Its pkg-config `.pc` file thus does not support static linking. See:
+    #     https://github.com/google/brotli/issues/795#issuecomment-1373595520
+    # and
+    #     https://github.com/google/brotli/pull/655#issuecomment-864395830
+    #
+    # In my opinion this is rather pointless, because `.a` files are always "static".
+    #
+    # We correct it here by renaming the files accordingly.
+    brotli = previous.brotli.overrideAttrs (old: {
+      postInstall = ''
+        for f in "$lib"/lib/*-static.a; do
+          ln -s --verbose "$f" "$(dirname "$f")/$(basename "$f" '-static.a').a"
+        done
+      '';
+    });
 
     # woff2 currently builds against the `brotli` static libs only with a patch
     # that's enabled by its `static` argument.
     woff2 = previous.woff2.override { static = true; };
 
+    libnfc = previous.libnfc.override { static = true; };
+
     # See comments on `statify_curl_including_exe` for the interaction with krb5!
     # As mentioned in [Packages that cause bootstrap compiler recompilation], we can't
     # override zlib to have static libs, so we have to pass in `zlib_both` explicitly
@@ -890,6 +914,11 @@ let
             # putting `curl_static` into `libraryPkgconfigDepends` is enough
             # and the manual modification of `configureFlags` is not necessary.
             libraryPkgconfigDepends = (old.libraryPkgconfigDepends or []) ++ pkgConfigNixPackages;
+            # `generic-builder.nix` already adds `pkg-config` as a `nativeBuildInput`
+            # e.g. if `libraryPkgconfigDepends` is not empty, but if it was, and we
+            # override it here, it does not notice, so we add `pkg-config` explicitly
+            # in that case.
+            buildTools = (old.buildTools or []) ++ [ pkgs.pkg-config ];
           });
 
 
@@ -1272,6 +1301,13 @@ let
                   [ final.openssl ]
                   "--libs openssl";
 
+              # This one needs `libcrypto` explicitly for reasons not yet investigated. `libpq` should pull it in via `openssl`.
+              postgresql-migration =
+                addStaticLinkerFlagsWithPkgconfig
+                  super.postgresql-migration
+                  [ final.openssl final.postgresql ]
+                  "--libs libpq libcrypto";
+
               xml-to-json =
                 addStaticLinkerFlagsWithPkgconfig
                   super.xml-to-json
@@ -1283,6 +1319,12 @@ let
                   # See https://github.com/curl/curl/issues/2775 for an investigation of why.
                   "--libs-only-L --libs-only-l libcurl expat";
 
+              nfc =
+                addStaticLinkerFlagsWithPkgconfig
+                  super.nfc
+                  [ final.libusb-compat-0_1 final.libusb1 ]
+                  "--libs libusb";
+
               # This package's dependency `rounded` currently fails its test with a patterm match error.
               aern2-real =
                 addStaticLinkerFlagsWithPkgconfig
@@ -1664,20 +1706,28 @@ in
         "cuda" # needs `allowUnfree = true`; enabling it gives `unsupported platform for the pure Linux stdenv`
         "debug" # `regex-base <0.94` on `regex-tdfa-text`
         "diagrams-builder" # `template-haskell >=2.5 && <2.16` on `size-based`
+        "diagrams-cairo" # `gtk2hs` bug building `glib`: https://github.com/nh2/static-haskell-nix/issues/4#issuecomment-1634681846
         "gloss-examples" # `base >=4.8 && <4.14` on `repa-io`
+        "gtk-sni-tray" # needs `gi-gtk` which requires `glib` which is problematic
         "gtk3" # Haskell package `glib` fails with `Ambiguous module name ‘Gtk2HsSetup’: it was found in multiple packages: gtk2hs-buildtools-0.13.8.0 gtk2hs-buildtools-0.13.8.0`
-        "H" # error: anonymous function at pkgs/applications/science/math/R/default.nix:1:1 called with unexpected argument 'javaSupport', at lib/customisation.nix:69:16
+        "H" # error: anonymous fun2rsyHqx27f4EQHEUjWU/libHScipher-aes-0.2.11-CpO2rsyHqx27f4EQHEUjWU.a(gf.o):(.text+0x0): first defined herection at pkgs/applications/science/math/R/default.nix:1:1 called with unexpected argument 'javaSupport', at lib/customisation.nix:69:16
+        "hackage-cli" # error: error: multiple definition of `gf_mul'; /nix/store/...-cipher-aes-0.2.11/lib/ghc-9.2.7/x86_64-linux-ghc-9.2.7/cipher-aes-0.2.11-[..]/libHScipher-aes-0.2.11-[..].a(gf.o):(.text+0x0): first defined here
         "hamilton" # `_gfortran_concat_string` linker error via openblas
         "hquantlib" # `time >=1.4.0.0 && <1.9.0.0` on `hquantlib-time`
         "ihaskell" # linker error
         "LambdaHack" # fails `systemd` dependency erroring on `#include <printf.h>`
         "language-puppet" # `base >=4.6 && <4.14, ghc-prim >=0.3 && <0.6` for dependency `protolude`
         "learn-physics" # needs opengl: `cannot find -lGLU` `-lGL`
+        "LPFP" # `gtk2hs` bug building `glib`: https://github.com/nh2/static-haskell-nix/issues/4#issuecomment-1634681846
         "magico" # undefined reference to `_gfortran_concat_string'
+        "monomer" # needs `nanovg` which is in this list
+        "nanovg" # needs opengl: `cannot find -lGLU` `-lGL`
         "odbc" # `odbcss.h: No such file or directory`
+        "pango" # `gtk2hs` bug building `glib`: https://github.com/nh2/static-haskell-nix/issues/4#issuecomment-1634681846
         "qchas" # `_gfortran_concat_string` linker error via openblas
         "rhine-gloss" # needs opengl: `cannot find -lGLU` `-lGL`
         "soxlib" # fails `systemd` dependency erroring on `#include <printf.h>`
+        "termonad" # needs `glib` which is problematic
       ];
 
     inherit normalPkgs;