Some more fixes from code review

satano · satano · commit 978a13cc9df6 · 2025-10-24T11:33:47.000+02:00
diff --git a/src/MigrationTools/Tools/ExportWorkItemMappingTool.cs b/src/MigrationTools/Tools/ExportWorkItemMappingTool.cs
@@ -22,7 +22,7 @@ public class ExportWorkItemMappingTool : Tool<ExportWorkItemMappingToolOptions>,
         WriteIndented = true,
     };
 
-    private readonly ConcurrentDictionary<string, string> _mappings = [];
+    private readonly ConcurrentDictionary<string, string> _mappings = new(StringComparer.OrdinalIgnoreCase);
 
     public ExportWorkItemMappingTool(
         IOptions<ExportWorkItemMappingToolOptions> options,
@@ -53,7 +53,6 @@ public void AddMapping(string sourceId, string targetId)
             return;
         }
         Log.LogDebug("Source work item ID '{sourceId}' is mapped to target work item ID '{targetId}'.", sourceId, targetId);
-        _mappings[sourceId] = targetId;
     }
 
     /// <summary>
@@ -125,7 +124,7 @@ private Dictionary<string, string> MergeWithExistingMappings(
         IDictionary<string, string> mappings,
         IDictionary<string, string> existingMappings)
     {
-        Dictionary<string, string> result = new(mappings);
+        Dictionary<string, string> result = new(mappings, StringComparer.OrdinalIgnoreCase);
 
         foreach (KeyValuePair<string, string> existingMapping in existingMappings)
         {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public class ExportWorkItemMappingTool : Tool<ExportWorkItemMappingToolOptions>,`
`22`	`22`	`WriteIndented = true,`
`23`	`23`	`};`
`24`	`24`
`25`		`- private readonly ConcurrentDictionary<string, string> _mappings = [];`
	`25`	`+ private readonly ConcurrentDictionary<string, string> _mappings = new(StringComparer.OrdinalIgnoreCase);`
`26`	`26`
`27`	`27`	`public ExportWorkItemMappingTool(`
`28`	`28`	`IOptions<ExportWorkItemMappingToolOptions> options,`
`@@ -53,7 +53,6 @@ public void AddMapping(string sourceId, string targetId)`
`53`	`53`	`return;`
`54`	`54`	`}`
`55`	`55`	`Log.LogDebug("Source work item ID '{sourceId}' is mapped to target work item ID '{targetId}'.", sourceId, targetId);`
`56`		`- _mappings[sourceId] = targetId;`
`57`	`56`	`}`
`58`	`57`
`59`	`58`	`/// <summary>`
`@@ -125,7 +124,7 @@ private Dictionary<string, string> MergeWithExistingMappings(`
`125`	`124`	`IDictionary<string, string> mappings,`
`126`	`125`	`IDictionary<string, string> existingMappings)`
`127`	`126`	`{`
`128`		`- Dictionary<string, string> result = new(mappings);`
	`127`	`+ Dictionary<string, string> result = new(mappings, StringComparer.OrdinalIgnoreCase);`
`129`	`128`
`130`	`129`	`foreach (KeyValuePair<string, string> existingMapping in existingMappings)`
`131`	`130`	`{`