lib: improve control abstraction coverage in frozen intrinsics

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #63698
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: Renegade334

lib/internal/freeze_intrinsics.js

@@ -31,6 +31,9 @@ const {
   ArrayPrototype,
   ArrayPrototypeForEach,
   ArrayPrototypePush,
+  AsyncFunctionPrototype,
+  AsyncGeneratorFunctionPrototype,
+  AsyncGeneratorFunctionPrototypePrototype,
   AsyncIteratorPrototype,
   Atomics,
   BigInt,
@@ -57,14 +60,19 @@ const {
   Float64ArrayPrototype,
   Function,
   FunctionPrototype,
+  GeneratorFunctionPrototype,
+  GeneratorFunctionPrototypePrototype,
   Int16Array,
   Int16ArrayPrototype,
   Int32Array,
   Int32ArrayPrototype,
   Int8Array,
   Int8ArrayPrototype,
+  Iterator,
+  IteratorHelperPrototype,
   IteratorPrototype,
   Map,
+  MapIteratorPrototype,
   MapPrototype,
   Number,
   NumberPrototype,
@@ -88,15 +96,15 @@ const {
   ReflectOwnKeys,
   RegExp,
   RegExpPrototype,
+  RegExpStringIteratorPrototype,
   SafeSet,
   Set,
+  SetIteratorPrototype,
   SetPrototype,
   String,
   StringIteratorPrototype,
   StringPrototype,
   Symbol,
-  SymbolIterator,
-  SymbolMatchAll,
   SymbolPrototype,
   SyntaxError,
   SyntaxErrorPrototype,
@@ -120,6 +128,7 @@ const {
   WeakRefPrototype,
   WeakSet,
   WeakSetPrototype,
+  WrapForValidIteratorPrototype,
   decodeURI,
   decodeURIComponent,
   encodeURI,
@@ -172,8 +181,7 @@ module.exports = function() {
     StringPrototype, // 22.1
     StringIteratorPrototype, // 22.1.5
     RegExpPrototype, // 22.2
-    // 22.2.7 RegExpStringIteratorPrototype
-    ObjectGetPrototypeOf(/e/[SymbolMatchAll]()),
+    RegExpStringIteratorPrototype, // 22.2.9
 
     // 23 Indexed Collections
     ArrayPrototype, // 23.1
@@ -194,11 +202,9 @@ module.exports = function() {
 
     // 24 Keyed Collections
     MapPrototype, // 24.1
-    // 24.1.5 MapIteratorPrototype
-    ObjectGetPrototypeOf(new Map()[SymbolIterator]()),
+    MapIteratorPrototype, // 24.1.5
     SetPrototype, // 24.2
-    // 24.2.5 SetIteratorPrototype
-    ObjectGetPrototypeOf(new Set()[SymbolIterator]()),
+    SetIteratorPrototype, // 24.2.6
     WeakMapPrototype, // 24.3
     WeakSetPrototype, // 24.4
 
@@ -211,10 +217,18 @@ module.exports = function() {
     FinalizationRegistryPrototype, // 26.2
 
     // 27 Control Abstraction Objects
-    // 27.1 Iteration
-    IteratorPrototype, // 27.1.2 IteratorPrototype
-    AsyncIteratorPrototype, // 27.1.3 AsyncIteratorPrototype
+    IteratorHelperPrototype, // 27.1.2
+    IteratorPrototype, // 27.1.3
+    WrapForValidIteratorPrototype, // 27.1.3.2.2.1
+    AsyncIteratorPrototype, // 27.1.4
     PromisePrototype, // 27.2
+    GeneratorFunctionPrototype, // 27.3
+    AsyncGeneratorFunctionPrototype, // 27.4
+    // 27.5 GeneratorPrototype
+    GeneratorFunctionPrototypePrototype,
+    // 27.6 AsyncGeneratorPrototype
+    AsyncGeneratorFunctionPrototypePrototype,
+    AsyncFunctionPrototype, // 27.7
 
     // Other APIs / Web Compatibility
     Console.prototype,
@@ -267,8 +281,7 @@ module.exports = function() {
     String, // 22.1
     StringIteratorPrototype, // 22.1.5
     RegExp, // 22.2
-    // 22.2.7 RegExpStringIteratorPrototype
-    ObjectGetPrototypeOf(/e/[SymbolMatchAll]()),
+    RegExpStringIteratorPrototype, // 22.2.9
 
     // 23 Indexed Collections
     Array, // 23.1
@@ -289,11 +302,9 @@ module.exports = function() {
 
     // 24 Keyed Collections
     Map, // 24.1
-    // 24.1.5 MapIteratorPrototype
-    ObjectGetPrototypeOf(new Map()[SymbolIterator]()),
+    MapIteratorPrototype, // 24.1.5
     Set, // 24.2
-    // 24.2.5 SetIteratorPrototype
-    ObjectGetPrototypeOf(new Set()[SymbolIterator]()),
+    SetIteratorPrototype, // 24.2.6
     WeakMap, // 24.3
     WeakSet, // 24.4
 
@@ -309,19 +320,19 @@ module.exports = function() {
     FinalizationRegistry, // 26.2
 
     // 27 Control Abstraction Objects
-    // 27.1 Iteration
-    ObjectGetPrototypeOf(ArrayIteratorPrototype), // 27.1.2 IteratorPrototype
-    // 27.1.3 AsyncIteratorPrototype
-    ObjectGetPrototypeOf(ObjectGetPrototypeOf(ObjectGetPrototypeOf(
-      (async function*() {})(),
-    ))),
+    IteratorHelperPrototype, // 27.1.2
+    Iterator, // 27.1.3
+    WrapForValidIteratorPrototype, // 27.1.3.2.2.1
+    ArrayIteratorPrototype, // 27.1.4
     Promise, // 27.2
     // 27.3 GeneratorFunction
-    ObjectGetPrototypeOf(function* () {}),
+    // 27.5 Generator
+    GeneratorFunctionPrototype,
     // 27.4 AsyncGeneratorFunction
-    ObjectGetPrototypeOf(async function* () {}),
+    // 27.6 AsyncGenerator
+    AsyncGeneratorFunctionPrototype,
     // 27.7 AsyncFunction
-    ObjectGetPrototypeOf(async function() {}),
+    AsyncFunctionPrototype,
 
     // 28 Reflection
     // eslint-disable-next-line node-core/prefer-primordials

lib/internal/per_context/primordials.js

@@ -263,10 +263,22 @@ function copyPrototype(src, dest, prefix) {
     name: 'ArrayIteratorPrototype',
     original: Reflect.getPrototypeOf(Array.prototype[Symbol.iterator]()),
   },
+  {
+    name: 'AsyncFunctionPrototype',
+    original: Reflect.getPrototypeOf(async function() {}),
+  },
+  {
+    name: 'AsyncGeneratorFunctionPrototype',
+    original: Reflect.getPrototypeOf(async function*() {}),
+  },
   {
     name: 'AsyncIteratorPrototype',
     original: Reflect.getPrototypeOf(Reflect.getPrototypeOf(async function*() {}).prototype),
   },
+  {
+    name: 'GeneratorFunctionPrototype',
+    original: Reflect.getPrototypeOf(function*() {}),
+  },
   {
     name: 'IteratorHelperPrototype',
     original: Reflect.getPrototypeOf(primordials.IteratorPrototypeDrop({ __proto__: null }, null)),

typings/primordials.d.ts

@@ -561,7 +561,10 @@ declare namespace primordials {
   export const IteratorPrototypeSymbolIterator: UncurryMethod<typeof Iterator.prototype, typeof Symbol.iterator>
   export const ArrayIteratorPrototype: ReturnType<typeof Array.prototype[typeof Symbol.iterator]>
   export const ArrayIteratorPrototypeNext: UncurryThis<typeof ArrayIteratorPrototype.next>
+  export const AsyncFunctionPrototype: Function
+  export const AsyncGeneratorFunctionPrototype: Function
   export const AsyncIteratorPrototype: AsyncIterable<any>
+  export const GeneratorFunctionPrototype: Function
   export const IteratorHelperPrototype: ReturnType<typeof Iterator.prototype.drop>
   export const MapIteratorPrototype: ReturnType<typeof Map.prototype[typeof Symbol.iterator]>
   export const MapIteratorPrototypeNext: UncurryThis<typeof MapIteratorPrototype.next>