Skip to content

Commit 6f3d2cb

Browse files
committed
fixup! crypto: support OpenSSL STORE private keys
1 parent a8e1270 commit 6f3d2cb

1 file changed

Lines changed: 9 additions & 12 deletions

File tree

test/parallel/test-crypto-sign-verify.js

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -639,16 +639,12 @@ QqHwKUNtIDE/uxxWNLBbYKaiLOWrbYA8skrWQWl3RkbXW4ZI28afRw9g
639639
MFkwEwYHKoZIzj0CAQYIKoEcz1UBgi0DQgAE1fiOx1BhdoAvpolZdyX46aGWlNoa
640640
2UKh8ClDbSAxP7scVjSwW2Cmoizlq22APLJK1kFpd0ZG11uGSNvGn0cPYA==
641641
-----END PUBLIC KEY-----`);
642-
const validOneShotSignature = Buffer.from(
643-
'3045022100cf800e13a0ead14be0ec9d614257fb6f409187642404dccb3a43' +
644-
'74ace9fc162602206bf6820b8902ae9ce4cd10708f188fddd5bc2a41db2c47' +
645-
'c003ca8265a00396ae',
646-
'hex');
647-
const streamingOnlySignature = Buffer.from(
648-
'3044022056cc3567aa4842c4b1c5f9de75059dbaf63efab5aa34097e5a85' +
649-
'47419aa3175e02206deb865046f12b25f111922da6858c7e97e475b656604' +
650-
'679bcd4a0b05d8c76f1',
651-
'hex');
642+
// Generate the signatures in-test so this checks API behavior rather than
643+
// provider-version-specific SM2 signature fixtures.
644+
const validOneShotSignature = crypto.sign('sm3', data, privateKey);
645+
const streamingSign = crypto.createSign('sm3');
646+
streamingSign.update(data);
647+
const streamingOnlySignature = streamingSign.sign(privateKey);
652648

653649
assert.strictEqual(
654650
crypto.verify('sm3', data, publicKey, validOneShotSignature),
@@ -657,9 +653,10 @@ MFkwEwYHKoZIzj0CAQYIKoEcz1UBgi0DQgAE1fiOx1BhdoAvpolZdyX46aGWlNoa
657653
crypto.verify('sm3', data, publicKey, streamingOnlySignature),
658654
false);
659655

660-
const generatedSignature = crypto.sign('sm3', data, privateKey);
656+
const streamingVerify = crypto.createVerify('sm3');
657+
streamingVerify.update(data);
661658
assert.strictEqual(
662-
crypto.verify('sm3', data, publicKey, generatedSignature),
659+
streamingVerify.verify(publicKey, streamingOnlySignature),
663660
true);
664661
}
665662

0 commit comments

Comments
 (0)