Commit 8df606c
Saiteja Bandaru
test_runner: do not read from process.argv and process.cwd() in run()
Currently the codebase for `runner.js` accesses some properties of
`process`, capturing options there. However, since `run()` is
exposed to end users, we should capture all this information in
`lib/internal/main/test_runner.js` and pass it down to `run()` as options.
This commit updates `run()` to default `cwd` to `.` instead of
reading `process.cwd()`, and substitutes `process.execArgv` with
the provided `execArgv` option when propagating V8 flags.
It also updates `test_runner.js` to explicitly pass these options.1 parent 41525ab commit 8df606c
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
| 210 | + | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| |||
730 | 730 | | |
731 | 731 | | |
732 | 732 | | |
733 | | - | |
| 733 | + | |
734 | 734 | | |
735 | 735 | | |
736 | 736 | | |
| |||
0 commit comments