lib: rename diagnostics_channel suppression option to subscriberId

Signed-off-by: Divyanshu Sharma <divyanshu88999@gmail.com>

Author: DivyanshuX9

lib/diagnostics_channel.js

@@ -36,31 +36,18 @@ const { subscribers: subscriberCounts } = dc_binding;
 const { WeakReference } = require('internal/util');
 const { isPromise } = require('internal/util/types');
 
-// Internal only: tracks a Set of active suppression keys for the current async
-// context. Uses a simple stack-based approach to avoid bootstrap issues with
-// async_hooks. This is a simplified implementation that works for typical usage.
-let suppressionStorage = null;
+let suppressionStorage;
 
 function getSuppressionsStorage() {
-  if (suppressionStorage === null) {
-    try {
-      const { AsyncLocalStorage } = require('async_hooks');
-      suppressionStorage = new AsyncLocalStorage();
-    } catch {
-      // If AsyncLocalStorage fails to initialize (rare), use a fallback
-      // that won't provide async context isolation but at least works
-      suppressionStorage = false; // Marker for "tried and failed"
-    }
+  if (suppressionStorage === undefined) {
+    const { AsyncLocalStorage } = require('async_hooks');
+    suppressionStorage = new AsyncLocalStorage();
   }
-  return suppressionStorage || undefined;
+  return suppressionStorage;
 }
 
 function withSuppressionsContext(set, fn, thisArg, args) {
-  const storage = getSuppressionsStorage();
-  if (storage) {
-    return storage.run(set, () => ReflectApply(fn, thisArg, args));
-  }
-  return ReflectApply(fn, thisArg, args);
+  return getSuppressionsStorage().run(set, () => ReflectApply(fn, thisArg, args));
 }
 // Can't delete when weakref count reaches 0 as it could increment again.
 // Only GC can be used as a valid time to clean up the channels map.
@@ -119,15 +106,14 @@ class RunStoresScope {
 
     // Enter stores using withScope
     if (activeChannel._stores) {
-      const storage = getSuppressionsStorage();
-      const activeKeys = storage ? storage.getStore() : undefined;
+      const activeKeys = getSuppressionsStorage().getStore();
       for (const entry of activeChannel._stores.entries()) {
         const store = entry[0];
-        const { transform, suppressedBy = null } = entry[1];
+        const { transform, subscriberId = null } = entry[1];
 
         // Skip this bound store if it opted into suppression and its key
         // is active in the current async context.
-        if (suppressedBy !== null && activeKeys?.has(suppressedBy)) {
+        if (subscriberId !== null && activeKeys?.has(subscriberId)) {
           continue;
         }
 
@@ -163,17 +149,17 @@ class RunStoresScope {
 class ActiveChannel {
   subscribe(subscription, options = {}) {
     validateFunction(subscription, 'subscription');
-    const suppressedBy = options && options.suppressedBy !== undefined ? options.suppressedBy : null;
-    if (suppressedBy !== null) {
-      const t = typeof suppressedBy;
+    const subscriberId = options && options.subscriberId !== undefined ? options.subscriberId : null;
+    if (subscriberId !== null) {
+      const t = typeof subscriberId;
       if (t === 'string' || t === 'number' || t === 'bigint' || t === 'boolean') {
-        throw new ERR_INVALID_ARG_TYPE('suppressedBy', ['object', 'symbol', 'function'], suppressedBy);
+        throw new ERR_INVALID_ARG_TYPE('subscriberId', ['object', 'symbol', 'function'], subscriberId);
       }
     }
 
     const handler = subscription;
     this._subscribers = ArrayPrototypeSlice(this._subscribers);
-    ArrayPrototypePush(this._subscribers, { handler, suppressedBy });
+    ArrayPrototypePush(this._subscribers, { handler, subscriberId });
     channels.incRef(this.name);
     if (this._index !== undefined) subscriberCounts[this._index]++;
   }
@@ -202,11 +188,11 @@ class ActiveChannel {
   }
 
   bindStore(store, transform, options = {}) {
-    const suppressedBy = options && options.suppressedBy !== undefined ? options.suppressedBy : null;
-    if (suppressedBy !== null) {
-      const t = typeof suppressedBy;
+    const subscriberId = options && options.subscriberId !== undefined ? options.subscriberId : null;
+    if (subscriberId !== null) {
+      const t = typeof subscriberId;
       if (t === 'string' || t === 'number' || t === 'bigint' || t === 'boolean') {
-        throw new ERR_INVALID_ARG_TYPE('suppressedBy', ['object', 'symbol', 'function'], suppressedBy);
+        throw new ERR_INVALID_ARG_TYPE('subscriberId', ['object', 'symbol', 'function'], subscriberId);
       }
     }
 
@@ -215,7 +201,7 @@ class ActiveChannel {
       channels.incRef(this.name);
       if (this._index !== undefined) subscriberCounts[this._index]++;
     }
-    this._stores.set(store, { transform, suppressedBy });
+    this._stores.set(store, { transform, subscriberId });
   }
 
   unbindStore(store) {
@@ -238,12 +224,11 @@ class ActiveChannel {
 
   publish(data) {
     const subscribers = this._subscribers;
-    const storage = getSuppressionsStorage();
-    const activeKeys = storage ? storage.getStore() : undefined;
+    const activeKeys = getSuppressionsStorage().getStore();
     for (let i = 0; i < (subscribers?.length || 0); i++) {
       try {
-        const { handler, suppressedBy = null } = subscribers[i];
-        if (suppressedBy !== null && activeKeys?.has(suppressedBy)) {
+        const { handler, subscriberId = null } = subscribers[i];
+        if (subscriberId !== null && activeKeys?.has(subscriberId)) {
           continue;
         }
         handler(data, this.name);
@@ -707,8 +692,7 @@ function suppressed(key, fn, thisArg, ...args) {
     throw new ERR_INVALID_ARG_TYPE('key', ['object', 'symbol', 'function'], key);
   }
 
-  const storage = getSuppressionsStorage();
-  const currentSet = storage ? storage.getStore() : undefined;
+  const currentSet = getSuppressionsStorage().getStore();
   const next = currentSet ? new SafeSet(currentSet) : new SafeSet();
   next.add(key);
   return withSuppressionsContext(next, fn, thisArg, args);