lib: brand-check Navigator getters to throw ERR_INVALID_THIS

Fixes: #63513

Signed-off-by: Mohamed Sayed <k@3zrv.com>

Author: Mohamed Sayed

lib/internal/navigator.js

@@ -11,6 +11,7 @@ const {
 
 const {
   ERR_ILLEGAL_CONSTRUCTOR,
+  ERR_INVALID_THIS,
 } = require('internal/errors').codes;
 
 const {
@@ -79,7 +80,9 @@ function getNavigatorPlatform(arch, platform) {
 }
 
 class Navigator {
-  // Private properties are used to avoid brand validations.
+  // Private properties also serve as a brand check via the `#field in obj`
+  // operator in each getter, so callers get a proper TypeError instead of
+  // an internal "private field" error when invoked on a non-Navigator `this`.
   #availableParallelism;
   #locks;
   #userAgent;
@@ -97,6 +100,7 @@ class Navigator {
    * @returns {number}
    */
   get hardwareConcurrency() {
+    if (!(#availableParallelism in this)) throw new ERR_INVALID_THIS('Navigator');
     this.#availableParallelism ??= getAvailableParallelism();
     return this.#availableParallelism;
   }
@@ -105,6 +109,7 @@ class Navigator {
    * @returns {LockManager}
    */
   get locks() {
+    if (!(#locks in this)) throw new ERR_INVALID_THIS('Navigator');
     this.#locks ??= require('internal/locks').locks;
     return this.#locks;
   }
@@ -113,6 +118,7 @@ class Navigator {
    * @returns {string}
    */
   get language() {
+    if (!(#languages in this)) throw new ERR_INVALID_THIS('Navigator');
     // The default locale might be changed dynamically, so always invoke the
     // binding.
     return getDefaultLocale() || 'en-US';
@@ -122,6 +128,7 @@ class Navigator {
    * @returns {Array<string>}
    */
   get languages() {
+    if (!(#languages in this)) throw new ERR_INVALID_THIS('Navigator');
     this.#languages ??= ObjectFreeze([this.language]);
     return this.#languages;
   }
@@ -130,6 +137,7 @@ class Navigator {
    * @returns {string}
    */
   get userAgent() {
+    if (!(#userAgent in this)) throw new ERR_INVALID_THIS('Navigator');
     this.#userAgent ??= `Node.js/${StringPrototypeSlice(nodeVersion, 1, StringPrototypeIndexOf(nodeVersion, '.'))}`;
     return this.#userAgent;
   }
@@ -138,6 +146,7 @@ class Navigator {
    * @returns {string}
    */
   get platform() {
+    if (!(#platform in this)) throw new ERR_INVALID_THIS('Navigator');
     this.#platform ??= getNavigatorPlatform(arch, platform);
     return this.#platform;
   }

test/parallel/test-navigator.js

@@ -147,3 +147,33 @@ Object.defineProperty(navigator, 'language', { value: 'for-testing' });
 assert.strictEqual(navigator.language, 'for-testing');
 assert.strictEqual(navigator.languages.length, 1);
 assert.strictEqual(navigator.languages[0] !== 'for-testing', true);
+
+{
+  const { Navigator } = globalThis;
+  const getterNames = [
+    'hardwareConcurrency',
+    'locks',
+    'language',
+    'languages',
+    'userAgent',
+    'platform',
+  ];
+  for (const name of getterNames) {
+    assert.throws(
+      () => Navigator.prototype[name],
+      {
+        name: 'TypeError',
+        code: 'ERR_INVALID_THIS',
+      },
+      `expected TypeError when reading ${name} on Navigator.prototype`,
+    );
+    assert.throws(
+      () => Reflect.get(Navigator.prototype, name, {}),
+      {
+        name: 'TypeError',
+        code: 'ERR_INVALID_THIS',
+      },
+      `expected TypeError when reading ${name} on a plain object`,
+    );
+  }
+}